Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106650
MIME-Version: 1.0
References: <CAFPFaMKz2Mz+bfjS3DGZmJUJ3vN4+6L-4PAWbj1PLwZAGyA-Tw@mail.gmail.com>
 <CAESVnVppKeJ8A-OCgjE6n5rG80nPxncDgSbK6mFFQ0uOE_BwMQ@mail.gmail.com>
 <CAOwTYAviBa48GbaBDo72pFijnMAVue680OcmD1HUA1FxawTi9g@mail.gmail.com> <CAFPFaMJ13oK+6SJdWTt3zv5_atjkbfeDJTx-SMgMgbH_3vrwwQ@mail.gmail.com>
In-Reply-To: <CAFPFaMJ13oK+6SJdWTt3zv5_atjkbfeDJTx-SMgMgbH_3vrwwQ@mail.gmail.com>
Date: Mon, 19 Aug 2019 11:55:06 +0200
Message-ID: <CAOwTYAvRiHgEqci4-+zdRoq-kGMvXMgvV66QkGu3Mb=ZEo-_sg@mail.gmail.com>
To: "G. P. B." <george.banyard@gmail.com>
Cc: Sara Golemon <pollita@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006b1a7e0590755615"
Subject: Re: [PHP-DEV] Removing old branches in php-src
From: krakjoe@gmail.com (Joe Watkins)

--0000000000006b1a7e0590755615
Content-Type: text/plain; charset="UTF-8"

I saw the list and the ages, what I didn't see was a justification for
removing them.

I think a proper analysis hasn't really been performed, for example the
native-tls branch was merged after ng into the 7.0 series, and I didn't
remove it because it serves as a reference point for the old vs the new way
without digging through a bunch of history/logs/whatever ...

These branches are costing us precisely nothing, just because they are old,
or you don't know what they are for doesn't mean they should be removed.
Good justifications include things like the branch causing confusing
amongst intended audience, a branch containing code so broken that it could
be considered malicious ... and I'm sure other reasons, none of which are
being presented ...

Cheers
Joe



On Mon, 19 Aug 2019 at 11:26, G. P. B. <george.banyard@gmail.com> wrote:

> Hello,
>
> I think the list compiled in the initial email done by *Gabriel Caruso*
> [1] is a good starting point.
>
> Copied here for reference.
>
> 15+ years old:
>
>    - experimental/RETURN_REF
>    - experimetnal/RETURN_REF_PATCH
>    - experimental/pre_new_hash_func
>    - experimental/zts_stdc_scanners
>    - experimental/rand_redesign
>    - migration/EXPERIMENTAL
>    - experimental/namespaces
>    - migration/unlabaled-1.67.2
>    - experimental/ZendEngine2
>    - experimental/apache_hooks
>    - experimental/apache_hooks
>    - migration/unlabaled-1.3.2
>
> 10+ years old:
>
>    - migration/unlabaled-1.29.2
>    - migration/INITIAL
>    - migration/sqlite-start
>
> Not even 5 years old, but no commit:
>
>    - str_size_and_int64_56_backport
>    - native-tls
>    - zend-signal-zts
>
> Not even 2 years old, but no commit:
>
>    - microseconds
>
>
> Just to be clear I'm not asking to remove Version branches not historical
> important ones, but mostly just the ones which have no commit, or are
> obsolete.
>
>
> Best regards
>
> George P. Banyard
>
> [1] https://externals.io/message/102982
>

--0000000000006b1a7e0590755615--