Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106586
MIME-Version: 1.0
References: <CAF+90c_Ctjja=8fR-uBWL1wDxZge771yMujMhaR_R2seKXciYw@mail.gmail.com>
 <CAOWwgpmsHMjnHuH4tfv_5-0f+pGKv2jJmA5v21FbkdpSHTbTJQ@mail.gmail.com>
 <25d774e8-183b-d39c-4ac4-81c1b7770229@gmail.com> <5d5298a5.1c69fb81.b4ed1.2d97SMTPIN_ADDED_MISSING@mx.google.com>
 <3db68c5e-54d1-812f-bbf5-1b089cba1bff@gmail.com> <5d52f72d.1c69fb81.8f95f.57a1SMTPIN_ADDED_MISSING@mx.google.com>
 <2bcb05d6-abf6-4fcb-599e-eaf4bcd58878@gmail.com> <CABdc3Wp+HWtbvab78T47sDuGQbBKkUagk-AL0qS4TO97AaoD6g@mail.gmail.com>
 <182a6bd5-4057-7ba1-2cca-ab0be37e0b75@gmail.com>
In-Reply-To: <182a6bd5-4057-7ba1-2cca-ab0be37e0b75@gmail.com>
Date: Wed, 14 Aug 2019 11:27:57 +0200
Message-ID: <CABdc3WoJzZGoxcLUzHoam=r+4bs7ED9j4+Oz+=+Jk+d_0S2yXA@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000195bef05901060ca"
Subject: Re: [PHP-DEV] [RFC] Namespace-scoped declares, again
From: michal@brzuchalski.com (=?UTF-8?Q?Micha=C5=82_Brzuchalski?=)

--000000000000195bef05901060ca
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=C5=9Br., 14 sie 2019 o 11:01 Rowan Collins <rowan.collins@gmail.com> napis=
a=C5=82(a):

> I don't see this as a problem. Right now, PHP doesn't care how many
> files you put your code in. As far as I know, you could concatenate the
> entirety of Laravel into one PHP file, and applications would not be
> able to tell the difference. Similarly, you could put the whole thing in
> a database and use eval() to execute it without touching any files.
>
>
That is true but not if there are any declare statements. If so it could
IMO work only like that:
<?php
package MyVendorMyLibrary {
    declare(strict_types =3D 1);
    class Foo {}
    namespace FooBar {
        class Baz {}
    }
}
package Other\Library {
    declare(strict_types =3D 0);
    declare(encoding =3D "UTF-8");
    class Awesome {}
}

This way declare directives could be set only once per package.
But that's conflicting with you above idea for package definition like that=
:
<?php
package MyVendorMyLibrary {
    declare(strict_types =3D 1);
}

I see no option to concatenate all source files any longer then?
Cause when PHP would know if it has to create package definition and not
look for it
and load it through autoload machinery?


> I think what attracts me to this idea is precisely that it doesn't
> require much extra machinery. We could even use the trick that PHPStorm
> uses for metadata stubs [1], and make the package definition look like
> valid executable PHP, but never actually execute it:
>
> package Foo {
>      const declare =3D [
>         'strict_types' =3D> 1,
>         'strict_operators' =3D> 1
>      ];
> }
>

How could that know when need look for package definition?
Example:

# src/Foo.php
<?php
package MyVendor\MyLibrary;
class Foo {}

You suggest that it would trigger autoload to load "MyVendor\MyPackage"
but current autoload machinery is able to load only classes,
not even functions or consts! cause it gets the only class name now.
It would need to be changed anyway.

--=20
regards / pozdrawiam,
--
Micha=C5=82 Brzuchalski
about.me/brzuchal
brzuchalski.com

--000000000000195bef05901060ca--