Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106542
MIME-Version: 1.0
References: <CAF+90c99ftVY4KndJAH_851sEAF===4iyUgSqrc3nEsL833BhQ@mail.gmail.com>
In-Reply-To: <CAF+90c99ftVY4KndJAH_851sEAF===4iyUgSqrc3nEsL833BhQ@mail.gmail.com>
Date: Sun, 11 Aug 2019 07:37:36 -0500
Message-ID: <CAESVnVqvSt_U8g=cwRu0pfEVrByYVmec_LHDa8jHtem95E=i9g@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000be2679058fd6ac8c"
Subject: Re: [PHP-DEV] Adding return types to internal methods (PHP 8)
From: pollita@php.net (Sara Golemon)

--000000000000be2679058fd6ac8c
Content-Type: text/plain; charset="UTF-8"

On Sun, Aug 11, 2019 at 3:44 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> What do you think about this? As we are currently annotating everything
> with types, and we're at a major version, this would be the ideal time to
> make this change. But there's certainly a BC break here. (And, for the
> record, this is not the type of BC break where P++ or editions help,
> without creating a larger mess.)
>
> I think your original proposal was spot on.  It added to the language
without creating any BC breaks. The ideal outcome.
This modification adds an admittedly small BC break for an equally small
benefit.

-1 from me.

-Sara

P.S. - Perhaps a way to the middle might be to introduce implicit return
type hints.  If a child method is implemented with no return type specified
on a parent method which has one, then the parent's type is assumed at bind
time, then we provide a better runtime error if that assumption is violated
in a strict_types=1 context which is the only place where strict covariance
of return types matters to PHP.

--000000000000be2679058fd6ac8c--