Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:106438 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 52273 invoked from network); 8 Aug 2019 16:49:56 -0000 Received: from unknown (HELO mail-vk1-f182.google.com) (209.85.221.182) by pb1.pair.com with SMTP; 8 Aug 2019 16:49:56 -0000 Received: by mail-vk1-f182.google.com with SMTP id u64so18758687vku.8 for ; Thu, 08 Aug 2019 07:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KBOeihMqXqsskOYR4lYWz60063jiMpEDPisoKKU+NOE=; b=Le12eMlVB3mcI/2QSJ3mHPAahqHRyuPar6CV5V1Ao9sCR3RulXFkLyHBvMfogtNVRy A64TqeNnhRtw8otnoievn4pTMZdp4wVqxPy2IIkEG8OCOZgNkjgHRWP13t0gsK3t1f5k f0JeSfToaZ3HTMxGvYbT1kKIfkD7ZWn7QZArE8S89szcALpWVCaJQiUZjUX6LY2zn0Tf Wz0DZONlC6PGCx4/XqvzzmabqwVbKSgHU8y2109HaFw5EgiNrcwa97rGde00UMRmaJhf i57vNWIYoPRgXS7kFHIizGeEp2F+OigxdnMikNFqLiHautV2mH9b5ikN2OdfwL7IClLI EpAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KBOeihMqXqsskOYR4lYWz60063jiMpEDPisoKKU+NOE=; b=cX/Gp3ayAUeb1SjRd40Rrt5aXLPwi7xwaHiTXgharR79R2g4dX5E7Jb02jvDCrXOAF u03BbeqCEAt3WJzWoWacXuVXace52WzmfKNRnSt2VwaY8xUmhQZSpwugDbU8BeDDM5pD eT3pFW8CmoFlG4rc6Dip3f6tmXovi/J1Jn/JHnEr63azGkaDd5TFqCbYN9518WMd1qo7 SPKkTm1QP+xKAA08VOI6+CJjuPGaGqRstG+JQ255E0e/s28GtZCu74PST5+r/+jwL6xg eAf5ruVSDN78HoBu8jNBPA8PUd2TxSqHF6wRrUUUPfGdE1U8PR+AVl4M1oskDyW8bKY5 z+zg== X-Gm-Message-State: APjAAAUJyOFF1hG8qh84RzknJICqTZafqT84bQ3bqiFudtKq2vhq5ogR v1vOjnwMBAiyUoPr2KnC6HxrNlNN0EOTl6OBxtQ= X-Google-Smtp-Source: APXvYqysbrm2TUD39FIRLuaOp7fH2ncUH4tcOEtdsZ0SR0V7uTPpSjUjaLJyH5/NW5WbwooiFjBKku6RezoPUk128aM= X-Received: by 2002:a1f:d1c3:: with SMTP id i186mr5781540vkg.26.1565273825673; Thu, 08 Aug 2019 07:17:05 -0700 (PDT) MIME-Version: 1.0 References: <1759114.DMe9nKvMbn@mcmic-probook> <62c73b8f-df41-43c2-bb51-ceeaf607cacf@Spark> In-Reply-To: Date: Thu, 8 Aug 2019 10:16:54 -0400 Message-ID: To: Zeev Suraski Cc: Brent , Internals , =?UTF-8?Q?C=C3=B4me_Chilliet?= Content-Type: multipart/alternative; boundary="0000000000005b089b058f9bb68a" Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags, again From: chasepeeler@gmail.com (Chase Peeler) --0000000000005b089b058f9bb68a Content-Type: text/plain; charset="UTF-8" On Thu, Aug 8, 2019 at 9:35 AM Zeev Suraski wrote: > On Thu, Aug 8, 2019 at 3:17 PM Brent wrote: > > > I asked similar questions on Twitter, where Zeev replied the following: > > https://mobile.twitter.com/zeevs/status/1158688885658046464 > > > I want to add a bit of color to this tweet: > - Estimated # of developers using PHP is at around 10M. This is based on > some extrapolation from an EDS report from ~8 years ago that estimated that > number at >6M, and growth rates we've seen beforehand. > - Anecdotally, I've seen it used many times in non-distributable code over > the years - a lot more frequently than once per 100 users. > - Even if just 1% of the userbase uses short tags, that's ~100K. We can > call this one a guess, but I'd say it's an educated guess that there's well > above 1% of the PHP userbase that uses short tags. > > It feels like much of the counter arguments are based on guesses without > > any real data to point to. > > > I wouldn't say they're guesses, but extrapolations - for instance, the fact > I'm aware of many PHP frameworks and apps, and am not aware of any single > one that allows short tags - makes me feel fairly comfortable to make the > statement that "virtually all frameworks and apps designed for public > consumption disallow short tags". I can't preclude the possibility that > the fact that all of the apps and frameworks I'm aware of don't allow short > tags is a remarkable coincidence - or that there are countless ones I'm not > aware of that do allow short tags - but I think that my theory is a lot > more plausible. > > I work on an internal application. Even though portability is not a concern for anything we write, we haven't used short tags since it was rumored they were going to be removed in PHP 6 many years ago. That being said, this application has been in development since 2003. There is a large amount of legacy code written before I even started here, not to mention plenty of horrible code written after I did start in 2005 (this was my first job). As I mentioned in an email on this thread yesterday, most of our legacy code is "just leave it alone, it works" code. We are in the process of rewriting things, but, that takes time. We try and mess with the legacy code as little as possible. Something as simple as auto formatting with PhpStorm has broken things in the past - so I don't trust an automated tool to fix the short tags for me. Even if I'm the only person that has participated in this thread that has to maintain a codebase that consists of non-portable code with a large amount of short tags, that's still at least 1% of those that have participated in this thread, or one of its predecessors. Another thing to keep in mind is that most of the people writing and/or maintaining "non-portable" code probably don't work for a company in the software development industry. When I want to upgrade PHP, I have to convince our leadership of the value of me spending a couple of weeks fixing BC breaks. I have to show why that is more valuable than spending time on the development of new functionality. The more time required to do an upgrade, the more likely it will get punted to a future date. I'm not against BC breaks in general - they are a necessary evil. However, it's important that the negative impact of that break is far outweighed by the positive value it brings. I'll leave it up to each of you to determine how positive of an impact removing short tags would bring. I can promise you, though, that the negative impact would be VERY large. Just because you don't personally have to maintain any code that uses short tags doesn't mean that there aren't other developers out there that do. Every BC break is going to lead to a subset of users that will decide to not upgrade as a result. It will also lead to a subset of users that will decide to use a different technology (node, .NET, python, etc.) going forward. Many BC breaks are worth that risk. Is this one of them? Many people have talked about the potential impacts of keeping short tags. I have yet to see anyone give an actual example where they have been negatively impacted by their existence. I've given you my personal story of how removing them will negatively impact my company. I welcome anyone that can provide an actual incident where the existence of short tags hurt them, or, the continued existence is likely to have a large negative impact on them in the future. > Zeev > -- Chase Peeler chasepeeler@gmail.com --0000000000005b089b058f9bb68a--