Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106188
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Mon, 08 Jul 2019 21:25:20 -0400
To: Ben Ramsey <ben@benramsey.com>
Cc: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= <bjorn.x.larsson@telia.com>, Theodore
 Brown <theodorejb@outlook.com>, PHP internals <internals@lists.php.net>
In-Reply-To: <24737D9E-EAAE-4763-913A-CE1CD291EC5E@benramsey.com>
References: <8442f1fa5544b2ca03e7cebbc64e8e5c@wkhudgins.info>
 <EECABEB0-D1E5-4438-A061-477C9BEDC024@simon.geek.nz>
 <eab667bf34e12ee2ad8b6bedabf66cc2@wkhudgins.info>
 <B6702192-0F94-4676-9B44-0DADD0E65060@simon.geek.nz>
 <683c5da474e13283030cac3d0c0ec080@wkhudgins.info>
 <2c37999d1e5372ae6ab48bfce5420796@wkhudgins.info>
 <CAF+90c-YBYSQGkmwS0qa68fpAcQxef_7SGa6LRkavamiwLtpRA@mail.gmail.com>
 <2CF672F8-12F5-4D37-8B8C-591A6E695220@benramsey.com>
 <78034520cdb610d923e25d47ed718938@wkhudgins.info>
 <CAF+90c_RkYUfvMtkwYhB2wy1uKfakAJxk4hjM2yLhNxt56L3UQ@mail.gmail.com>
 <000a01d52e91$2a4b6f20$7ee24d60$@jhdxr.com>
 <93528f103c149b7c48e8f35914049d06@wkhudgins.info>
 <97884add-88fd-e09e-92c6-2c1b68c579f5@xs4all.nl>
 <22ac19ecaf897370facfe9fd0a8b1993@wkhudgins.info>
 <0f8ab2d1-c308-7168-0aba-a5bcf327c3ad@telia.com>
 <4d340e64db8d81f47cd7e4f7d3a4c268@wkhudgins.info>
 <DM5PR06MB2857F28984D5F95554ACB32EDEF70@DM5PR06MB2857.namprd06.prod.outlook.com>
 <660880c5-6273-1f6d-2181-3cb4c67fb508@telia.com>
 <24737D9E-EAAE-4763-913A-CE1CD291EC5E@benramsey.com>
Message-ID: <b065547bb16bab6c6a6862f540cf7186@wkhudgins.info>
User-Agent: Roundcube Webmail/1.3.3
Subject: Re: [PHP-DEV] [VOTE] Voting opens for str_starts_with and ends_with
 functions
From: will@wkhudgins.info

On 2019-07-08 17:52, Ben Ramsey wrote:
>> On Jul 8, 2019, at 13:09, Björn Larsson <bjorn.x.larsson@telia.com> 
>> wrote:
>> 
>> Having this _ci postfix is  a new way of indicating case 
>> insensitivity.
>> I think that it might add to negative votes. Personally I think it's a
>> good idea to mimic existing ways, even if they are a bit awkward.
>> 
>> How about using a flag or following "tradition", like stri_starts_with
>> & stri_ends_with or str_istarts_with & str_iends_with? That would
>> follow strstr / stristr and str_replace / str_ireplace.
>> 
>> I have no voting rights though.
> 
> 
> I made this recommendation earlier in the other thread
> (<https://externals.io/message/94787#106035>), but it didn’t get any
> traction or response:
> 
>> maybe the signatures could be revised to pass a third parameter?
>> 
>> str_starts_with($haystack, $needle, $case_sensitive = true): bool
> 
> Since voting has already begun, is this something that could still be
> considered?
> 
> -Ben

Thanks for the interest everyone! I've been following the email thread 
and have a few thoughts.

- At one point I had it set to take case sensitivity as a parameter 
(https://github.com/php/php-src/pull/2049/commits/f89d8edc5f32d8a4b702699209e72d864e2ca440). 
That isn't a bad idea IMO. I changed it to have split functions to match 
str_ireplace, stripos, etc.

- I agree the *_ci naming convention is different than most of the 
existing codebase, but a lot of discussion during the process led to the 
*_ci naming convention. And while the *_ci naming convention isn't 
traditional, it does seem more intuitive. The i is easier to read in 
something short like "str_ireplace" but kind of gets lost in something 
long like "str_istarts_with".

- I'd considered splitting the vote into 3 parts:
      1) str_starts_with and str_ends_with
      2) str_starts_with_ci and str_ends_with_ci
      3) The mb_* functions.

      But I decided against that as I felt that might be overly splitting 
up the proposal.

If the main issue is naming and not functionality, I am happy to rework 
the RFC (if it fails) to be more palatable. I primarily would like to 
add this functionality to PHP, regardless of the naming. In my opinion 
one of the nice things about PHP is that it comes with so many things 
under the hood. As a user of the language that is something I 
appreciate. A lot of powerful functionality is baked into the language 
and that functionality is available on almost every web host. A language 
like Python or Java just can't compare in that respect. Even NodeJS 
requires an extensive amount of packages to accomplish even simple 
tasks. PHP is nice because it ships with "batteries" included. Sure, 
that brings some issues along with it, but that is as much a strength of 
the language as it is a challenge. Adding a common task like starts_with 
and ends_with seems like a reasonable thing to do.

Thanks,

Will