Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106179
MIME-Version: 1.0
References: <1562591120.659818.23020.47476@mail.rambler.ru>
 <7ff385f1-b86d-e56d-4133-e2f101afa13e@gmx.de> <FB6DFBC5-21F1-4219-8C49-09DDE811938E@gmail.com>
In-Reply-To: <FB6DFBC5-21F1-4219-8C49-09DDE811938E@gmail.com>
Date: Mon, 8 Jul 2019 19:52:41 +0300
Message-ID: <CAPhkiZyLDd=SFOguqPFX-638VN4oor9z7bTAgOyJuA1FPN30VA@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, Andrew Gromov <andrewgrom@rambler.ru>, 
	internals <internals@lists.php.net>, Marco Pivetta <ocramius@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [VOTE] Voting opens for str_starts_with and
 ends_with functions
From: narf@devilix.net (Andrey Andreev)

Hi,

On Mon, Jul 8, 2019 at 4:54 PM Claude Pache <claude.pache@gmail.com> wrote:
>
>
> > Le 8 juil. 2019 =C3=A0 15:20, Christoph M. Becker <cmbecker69@gmx.de> a=
 =C3=A9crit :
> >
> > FTR, there is already substr_compare().
>
> `substr_compare()` (as well as `strncmp()` which I am currently using in =
lieu of `str_starts_with()`) forces you to provides the substring and the l=
ength of the substring, instead of just the substring:
>
>      substr_compare('foobarbaz', 'foo', 0, 3) =3D=3D=3D 0
>      strncmp('foobarbaz', 'foo', 3) =3D=3D=3D 0
>      str_starts_with('foobarbaz', 'foo')
>

The existence of substr_compare() and strncmp() is also my main
motivation for voting No, though I also share Zeev's reasoning.

You're right that the 2 already existing functions are a bit less
convenient to use, but the RFC doesn't even try to make a case for
that, so how do we know this was even considered? While I'm not
against having more than one way of doing things, I do think we need a
compelling enough reason to add a third way of doing the same thing
and here we don't even have an attempt to convince us.

Cheers,
Andrey.