Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106176
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
	s=turbo-smtp; d=php.net;
	h=Received:Received:X-TurboSMTP-Tracking:X-Gm-Message-State:X-Google-Smtp-Source:X-Received:MIME-Version:References:In-Reply-To:From:Date:X-Gmail-Original-Message-Id:Message-ID:Subject:To:Cc:Content-Type;
	b=VuRKP158hZvbg0oaia8aoRN3eSqjsVNbbMxTfOf5lqMaTabn6tbV8krQspTbko
	HQuWD7cJCn6s9oYWEIHR3uFexEN3b8r1GkauhTW9XhKvmRsllL3TVIdqrQKR3rWe
	a0bUkG/YFFODvRpwsNv6wJID9GjikTuvOIHoP850h3jlM=;
MIME-Version: 1.0
References: <1562591120.659818.23020.47476@mail.rambler.ru> <7ff385f1-b86d-e56d-4133-e2f101afa13e@gmx.de> <FB6DFBC5-21F1-4219-8C49-09DDE811938E@gmail.com>
In-Reply-To: <FB6DFBC5-21F1-4219-8C49-09DDE811938E@gmail.com>
Date: Mon, 8 Jul 2019 17:35:43 +0300
Message-ID: <CAJHtznx4zrGTSjRdF5GZfvgynXz12CfQ+LhE+Bi8KMdgjCRP5A@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, Andrew Gromov <andrewgrom@rambler.ru>,  internals <internals@lists.php.net>, Marco Pivetta <ocramius@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000958d28058d2c5c52"
Subject: Re: [PHP-DEV] Re: [VOTE] Voting opens for str_starts_with and ends_with functions
From: zeev@php.net (Zeev Suraski)

--000000000000958d28058d2c5c52
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 8, 2019 at 4:53 PM Claude Pache <claude.pache@gmail.com> wrote:

>
> > Le 8 juil. 2019 =C3=A0 15:20, Christoph M. Becker <cmbecker69@gmx.de> a
> =C3=A9crit :
> >
> > FTR, there is already substr_compare().
>
> `substr_compare()` (as well as `strncmp()` which I am currently using in
> lieu of `str_starts_with()`) forces you to provides the substring and the
> length of the substring, instead of just the substring:
>
>      substr_compare('foobarbaz', 'foo', 0, 3) =3D=3D=3D 0
>      strncmp('foobarbaz', 'foo', 3) =3D=3D=3D 0
>      str_starts_with('foobarbaz', 'foo')


Explaining my 'no' vote (I was quite undecided on it).

Generally, I think it's a Good Thing to have startsWith/endsWith functions
in PHP.  However, several things made me eventually vote 'no' on this
proposal at this point in time:

1.  I'm still hopeful that we would one day clean up the global namespace
by creating a new set of namespacecd functions that would be consistent in
naming, semantics and argument order.  It feels wrong to add more to the
mess right now...
2.  Unless I'm mistaken, these functions introduce a new kind of notation
for case insensitivity that we don't presently have in PHP (_ci()).  Maybe
it's a good option, but having a new 3rd or 4th notation feels wrong.
3.  Given one can relatively easily (if not as elegantly) use
substr_compare() to implement startsWith()/endsWith(), the added value
doesn't appear to me to be worth the downsides.

Zeev


>

--000000000000958d28058d2c5c52--