Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106175
MIME-Version: 1.0
References: <CAJW__o0GLjcagzF0ZpEK54yyhkFpgV6tm4p+ihnZvv-dC3YFUQ@mail.gmail.com>
 <32BFA854-5FDB-4F56-941C-3B9F23D6D2E3@gmail.com>
In-Reply-To: <32BFA854-5FDB-4F56-941C-3B9F23D6D2E3@gmail.com>
Date: Mon, 8 Jul 2019 16:14:47 +0200
Message-ID: <CAF+90c83+rfRVW4SrLD=vsXe8_gHKY-yHcpVD+=u8xLOtEWGgw@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: Kalle Sommer Nielsen <kalle@php.net>, Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000083a12058d2c128f"
Subject: Re: [PHP-DEV] [RFC] Deprecations for 7.4
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000083a12058d2c128f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 8, 2019 at 3:41 PM Claude Pache <claude.pache@gmail.com> wrote:

> The deprecation RFC lists `apache_request_headers()`, because it is =E2=
=80=9Can
> Apache-specific name is also available in other SAPIs, even though it is
> also available under the SAPI-independent name getallheaders()=E2=80=9D.
>
> Have you ever thought about making a more thorough and consistent change
> with other similar functions, instead of just picking one particular
> function because it is the only one in its category that has a documented
> alias? In five minutes, I=E2=80=99m thinking of the following obvious thi=
ngs:
>
> * using a less ambiguous name than `getallheaders()`, given the existence
> of both `apache_request_headers()` and `apache_response_headers()`;
>
> * renaming all `apache_*()` functions that are available in other SAPI
> into a SAPI-independent name;
>
> * treating all `nsapi_*()` functions as well.
>

Thanks for bringing this up. I agree with you, and have dropped
apache_request_headers() from this RFC. This clearly needs a more
comprehensive change. Note that nsapi no longer exists since PHP 7, but
litespeed also has its own variation of these functions as well.

Nikita

--000000000000083a12058d2c128f--