Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106162
To: "internals" <internals@lists.php.net>, "theodorejb" <theodorejb@outlook.com>
Reply-To: "Andrew Gromov" <andrewgrom@rambler.ru>
Date: Mon, 8 Jul 2019 13:15:29 +0300
Content-Transfer-Encoding: 7bit
Content-Type: multipart/alternative; boundary="_----------=_15625809292748724"
Message-ID: <1562580929.565898.27487.49640@mail.rambler.ru>
MIME-Version: 1.0
Subject: Re: [VOTE] Voting opens for str_starts_with and ends_with functions
From: andrewgrom@rambler.ru ("Andrew Gromov")

--_----------=_15625809292748724
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"; format="flowed"

> For those voting against adding these functions, can you clarify why?
> Do you dislike how they are named, or do you not see the need for the
> case insensitive versions, or is there an issue with the implementation?


I believe that star_with/end_with is useful, but not in this form.
The standard library has 98 string functions with different naming styles.
Adding 4 more (8 for mb_) functions for actually two(one?) tasks is redunda=
nt.

I think that more discussion is needed.

My preferred variants:

1) One function

```php
str_contains(
    $haystack,=20
    $needle,=20
    [CASE_INSENSITIVE|FROM_BEGIN|FROM_END|MULTI_BYTE] =3D 0,=20
    [$encoding] =3D utf8
)
```

2)Or two

```php
str_starts_with(...see above, but without FROM_BEGIN|FROM_END)
str_ends_with(...see above, but without FROM_BEGIN|FROM_END)
```

Best regards,Andrey

--_----------=_15625809292748724--