Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106159
To: "will@wkhudgins.info" <will@wkhudgins.info>, 'PHP internals'
	<internals@lists.php.net>
Thread-Topic: [PHP-DEV] [VOTE] Voting opens for str_starts_with and ends_with
 functions
Thread-Index: AQHVMtc2W38yFGmQ7UeluZx90vX1fKa/mvqi
Date: Sun, 7 Jul 2019 20:45:50 +0000
Message-ID:
 <DM5PR06MB2857F28984D5F95554ACB32EDEF70@DM5PR06MB2857.namprd06.prod.outlook.com>
References: <8442f1fa5544b2ca03e7cebbc64e8e5c@wkhudgins.info>
 <EECABEB0-D1E5-4438-A061-477C9BEDC024@simon.geek.nz>
 <eab667bf34e12ee2ad8b6bedabf66cc2@wkhudgins.info>
 <B6702192-0F94-4676-9B44-0DADD0E65060@simon.geek.nz>
 <683c5da474e13283030cac3d0c0ec080@wkhudgins.info>
 <2c37999d1e5372ae6ab48bfce5420796@wkhudgins.info>
 <CAF+90c-YBYSQGkmwS0qa68fpAcQxef_7SGa6LRkavamiwLtpRA@mail.gmail.com>
 <2CF672F8-12F5-4D37-8B8C-591A6E695220@benramsey.com>
 <78034520cdb610d923e25d47ed718938@wkhudgins.info>
 <CAF+90c_RkYUfvMtkwYhB2wy1uKfakAJxk4hjM2yLhNxt56L3UQ@mail.gmail.com>
 <000a01d52e91$2a4b6f20$7ee24d60$@jhdxr.com>
 <93528f103c149b7c48e8f35914049d06@wkhudgins.info>
 <97884add-88fd-e09e-92c6-2c1b68c579f5@xs4all.nl>
 <22ac19ecaf897370facfe9fd0a8b1993@wkhudgins.info>
 <0f8ab2d1-c308-7168-0aba-a5bcf327c3ad@telia.com>,<4d340e64db8d81f47cd7e4f7d3a4c268@wkhudgins.info>
In-Reply-To: <4d340e64db8d81f47cd7e4f7d3a4c268@wkhudgins.info>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [Y2vI1xR9o+rWOwlObu3vlqUHHXSWP9RF]
x-ms-publictraffictype: Email
x-incomingheadercount: 43
x-eopattributedmessage: 0
x-microsoft-antispam:
 BCL:0;PCL:0;RULEID:(2390118)(5050001)(7020095)(20181119110)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031322404)(2017031323274)(2017031324274)(1601125500)(1603101475)(1701031045);SRVR:CY1NAM02HT063;
x-ms-traffictypediagnostic: CY1NAM02HT063:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-message-info:
 V0E3jn6GpFcEylY/8A7nIK/oJsMXogK1ct6BIXCI8lA61RjgOJUCiWcO88o/DqQJoOB00rwjlaUyVWJcGXks+ZjVRtvFLenEd/gh39+HjLqNNZxsH0e3H9NSs05cKuHn5rkA60c1LlyVaX05bNkCs48fZHD8oijXIuNKodRqYVGfrr5x/YE4Qo5tUtvvjgkS
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: bf7523bb-13ed-4eff-bcb3-08d7031c1903
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2019 20:45:50.8686
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT063
Subject: Re: [PHP-DEV] [VOTE] Voting opens for str_starts_with and ends_with
 functions
From: theodorejb@outlook.com (Theodore Brown)

On Thu, July 4, 2019 at 9:13 PM Will <will@wkhudgins.info> wrote:=0A=
=0A=
> Hello all,=0A=
>=0A=
> After 15 days of discussion I have opened up voting on the following=0A=
> RFC (https://wiki.php.net/rfc/add_str_begin_and_end_functions).=0A=
=0A=
=0A=
Thank you for your work on this. I'm surprised that so far the vote=0A=
is so controversial, with 8 votes in favor and 8 opposed.=0A=
=0A=
For those voting against adding these functions, can you clarify why?=0A=
Do you dislike how they are named, or do you not see the need for the=0A=
case insensitive versions, or is there an issue with the implementation?=0A=
=0A=
Personally I'd find the basic `str_starts_with` and `str_ends_with`=0A=
functions very valuable. Currently I either have to implement functions=0A=
like this myself in almost every script, or else write repetitious=0A=
code like the following:=0A=
=0A=
```php=0A=
$needle =3D "foobar";=0A=
=0A=
if (substr($haystack, 0, strlen($needle)) =3D=3D=3D $needle) {=0A=
    // starts with "foobar"=0A=
}=0A=
```=0A=
=0A=
To avoid repetition, many developers use the following pattern instead:=0A=
=0A=
```php=0A=
if (strpos($haystack, "foobar") =3D=3D=3D 0) {=0A=
    // starts with "foobar"=0A=
}=0A=
```=0A=
=0A=
However, with longer strings this becomes far less efficient, since PHP=0A=
has to search through the entire haystack to find the needle position.=0A=
=0A=
If this RFC is accepted, these awkward and inefficient approaches=0A=
could be replaced with straightforward and fast code like this:=0A=
=0A=
```php=0A=
if (str_starts_with($haystack, "foobar")) {=0A=
    // ...=0A=
}=0A=
```=0A=
=0A=
Please vote on the RFC if you haven't already. Clarification would be=0A=
appreciated if don't feel that these functions would be a good addition.=0A=
=0A=
Best regards,=0A=
Theodore=