Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106128
MIME-Version: 1.0
References: <e14624ddab96a45b94f4e7504be4c1ac@exussum.co.uk>
 <008001d526a0$a6ac24e0$f4046ea0$@jhdxr.com> <5a5d7c1247d0d75591980c1571f12dbc@exussum.co.uk>
In-Reply-To: <5a5d7c1247d0d75591980c1571f12dbc@exussum.co.uk>
Date: Tue, 2 Jul 2019 18:38:12 +0200
Message-ID: <CAF+90c87=HhQch394-AQBtkxOFEKWC3rRrWjANb5QaUsmipuMg@mail.gmail.com>
To: Scott Dutton <scott@exussum.co.uk>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d953d9058cb55f3e"
Subject: Re: [PHP-DEV] [RFC] [Vote] Base convert changes
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000d953d9058cb55f3e
Content-Type: text/plain; charset="UTF-8"

On Mon, Jul 1, 2019 at 4:09 PM Scott Dutton <scott@exussum.co.uk> wrote:

> Hi all
>
> I have made a PR for 7.4 for just the ignoring invalid input.  I will
> open a similar one for PHP 8.
>
> https://github.com/php/php-src/pull/4328
>
> All tests have been fixed for linux, there is one failure for windows
> which I am looking in to.
>
> Voting ends in a few days time so last chance to vote. looks like the
> negative number part is not going to pass so the PR has not been
> updated.
> Link to RFC if you need it -
> https://wiki.php.net/rfc/base_convert_improvements
>
> Any questions please let me know
>
> Thanks
>
> Scott
>

A possibility to consider would to only support negative numbers in bindec,
octdec and hexdec. Allowing negative numbers wouldn't change any existing
behavior (assuming we consider the leading "-" an error before, as we would
per this RFC). The problem is only on the decbin, decoct and dechex side,
where we currently treat the input as unsigned. base_convert could also
support negative numbers, though it might need some implementation changes
(it would be great to make base_convert directly work from string -> string
to avoid the float precision loss.)

Nikita

--000000000000d953d9058cb55f3e--