Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106119
MIME-Version: 1.0
References: <CAG9XoMQpojXq4fiLgqgi_9+ACTsrk3JLGGo4-0z5PiixtF33Ng@mail.gmail.com>
 <eb84978b97ef8e9481e8263f19e9456cf0f9ab24.camel@schlueters.de>
 <8f07c0dc-f9a5-8c76-1d48-0fac762bfc4f@gmail.com> <CAG9XoMSA5dZ+QYGiEC0+ObVnZqt44rojZo20y4nRSEg=zBFMtg@mail.gmail.com>
 <92dba455-17df-41dd-c523-bb0db3c12078@gmail.com> <003b01d52e49$4db89390$e929bab0$@jhdxr.com>
 <CAF+90c_8Yr7m+n1ys6g10EccSM31TT=XFtAm82bQai9XV9v8wA@mail.gmail.com>
 <000001d52e8f$a1f92b40$e5eb81c0$@jhdxr.com> <CAF+90c9gb3PHhAtzeHDou37aNtLeVeM4QpPzRxc9H0Km3442mw@mail.gmail.com>
 <CAG9XoMTPfw+hpVg-oVFAQghsFTOnWstJWYcf=Gc_sWydHN+5xA@mail.gmail.com>
 <CAF+90c_MBgCRP67O=Y7BZynkbWofdqzoSuQDrNBE7ixmmHTYgw@mail.gmail.com>
 <CADVQu1SyBXCgtAaB4CPZiWYpMvbWS9+R3FQHKdX_cGE71jiZNQ@mail.gmail.com> <CAF+90c9dCQJfDc9-zT9wSLx2iHOheUfpZ9PqpJK2JYppZ4kSPQ@mail.gmail.com>
In-Reply-To: <CAF+90c9dCQJfDc9-zT9wSLx2iHOheUfpZ9PqpJK2JYppZ4kSPQ@mail.gmail.com>
Date: Sun, 30 Jun 2019 00:19:53 +0200
Message-ID: <CAG9XoMQTzMbDz0TAxeppS9TmTBEdnFD2oixnHgktPdsGta0X4g@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: David Walker <dave@mudsite.com>, CHU Zhaowei <me@jhdxr.com>, 
	PHP Internals <internals@lists.php.net>, Stanislav Malyshev <smalyshev@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000042c52058c7dcc52"
Subject: Re: [PHP-DEV] Memory leak in eval()'d code
From: benjamin.morel@gmail.com (Benjamin Morel)

--000000000000042c52058c7dcc52
Content-Type: text/plain; charset="UTF-8"

>
> What is the "non scaled case"? To repeat what I said earlier: Without eval
> there is no and will not be a leak.
> The bug is that eval() currently reuses an existing class instead of
> creating a new one each time. Calling get_class(eval("return new class
> {};")) should be returning a new string every time, while for OPs script it
> currently does not.
> tl;dr:
> while (1) {
>     get_class(new class {}); // should always return the same
>     get_class(eval("return new class {};")); // should always return
> different, currently may return same due to bug
> }

Ok thank you, anyway the good news is that I found a workaround for now
(creating classes of a given type once then cloning). And if I understand
correctly, once the issue you mention is resolved (and get_class() returns
a distinct class every time), I should have another alternative:

```
$object = eval('return new class (...) {};');
$class = get_class($object);
$anotherObjectOfSameClass = new $class();
```

And I do understand that my use case is border line, and does not deserve
too much attention.
It's very useful to be able to perform instanceof on objects that
dynamically implement an arbritary set of interfaces, though.

Ben

--000000000000042c52058c7dcc52--