Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:106089 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 13717 invoked from network); 28 Jun 2019 17:43:35 -0000 Received: from unknown (HELO mail.experimentalworks.net) (84.19.169.162) by pb1.pair.com with SMTP; 28 Jun 2019 17:43:35 -0000 Received: from maniacmansion.fritz.box (ppp-188-174-56-116.dynamic.mnet-online.de [188.174.56.116]) by mail.experimentalworks.net (Postfix) with ESMTPSA id A7F94539DE; Fri, 28 Jun 2019 17:00:29 +0200 (CEST) Message-ID: <42b3389e8aca04aba85e7bc9951208d14f2846f5.camel@schlueters.de> To: Remi Collet , internals@lists.php.net Cc: Andrey Hristov Date: Fri, 28 Jun 2019 17:00:29 +0200 In-Reply-To: <48bc49fc-68b8-3f5e-d37a-1bc990048753@fedoraproject.org> References: <48bc49fc-68b8-3f5e-d37a-1bc990048753@fedoraproject.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] State of libmysql? From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=) On Fri, 2019-06-28 at 15:04 +0200, Remi Collet wrote: > Le 28/06/2019 à 14:59, Nikita Popov a écrit : > > Hi internals, > > > > Building PHP 7.4 against libmysql rather than mysqlnd has been > > broken for > > quite a while and only recently noticed in > > https://github.com/php/php-src/pull/4316. Clearly none of us are > > using > > libmysql and none of our CI jobs test it. Now that it compiles > > again, there > > are many build warnings, as well as about 10 failing PDO MySQL > > tests and 20 > > failing MySQLi tests. > > > > This is not good. I think that we either need an interested party > > to > > support these bindings, or else drop support for building against > > libmysql. I think andrey did some experiments reccently. I haven't looked into it in a while. There are sometimes benefits where some operations can be used via libmysql, but not mysqlnd, while mysqlnd has benefits. Dropping libmysql-support would make the code easier, but also limit abilities. (especially in case where mariadb and mysql protocol diverge) > +1 to drop support for libmysqlclient. > > BTW license is NOT compatible with PHP. I am no lawyer, but imo that is incorrect. a) libmysql is licensed under GPL+universal FOSS exception, which allows combination with OSI-approved licenses, to which PHP License belongs https://oss.oracle.com/licenses/universal-foss-exception/ b) there is a commercial version of libmysql, which doesn't have GPL's virality johannes