Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:106040
MIME-Version: 1.0
References: <CAJW__o0GLjcagzF0ZpEK54yyhkFpgV6tm4p+ihnZvv-dC3YFUQ@mail.gmail.com>
 <CAPhkiZykcKifdxkPrn8j5SRoGw2ZPQYySvwh1YPGUtio-yHv_Q@mail.gmail.com> <CAF+90c_6aOz-muUFdK0MDh1U+uRiBKirKLKPeVrhR5p9V7oALw@mail.gmail.com>
In-Reply-To: <CAF+90c_6aOz-muUFdK0MDh1U+uRiBKirKLKPeVrhR5p9V7oALw@mail.gmail.com>
Date: Sun, 23 Jun 2019 00:33:27 +0300
Message-ID: <CAPhkiZzeWPBA2bWTYmbZ7YPMYkRAwC1Js9TwW5=oup_=gW+eng@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Kalle Sommer Nielsen <kalle@php.net>, Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Deprecations for 7.4
From: narf@devilix.net (Andrey Andreev)

Hi,

On Sat, Jun 22, 2019 at 3:59 PM Nikita Popov <nikita.ppv@gmail.com> wrote:
>
> On Sat, Jun 22, 2019 at 2:24 PM Andrey Andreev <narf@devilix.net> wrote:
>>
>> Hi,
>>
>> With regards to the array_key_exists() deprecation, the RFC currently
>> says nothing about things like ArrayAccess and object properties that
>> contain arrays. I'm sure that these are exceptions that aren't meant
>> to be deprecated, but can you please specify that explicitly? We all
>> know how little bits like that can result in awful outcomes.
>
>
> Thanks for bringing this up: It's a great example of why this needs to be=
 deprecated. array_key_exists() actually has no support for ArrayAccess obj=
ects at all -- it only operates on (mangled) object properties. But just se=
eing the name and the fact that it doesn't error when passed an ArrayAccess=
 object, it's quite easy to jump to the wrong conclusion. I've updated the =
RFC to mention this now.
>

Well, then I guess actually implementing ArrayAccess support should be
brought up now, but other than that the updated RFC content makes much
more sense now. Thank you.

> I don't understand what you mean by "object properties that contain array=
s" though, or rather how that related to array_key_exists().
>

I had a minor brain fart while originally thinking about this and it's
actually nothing. Sorry about that.

Cheers,
Andrey.