Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105982 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 68602 invoked from network); 19 Jun 2019 10:28:57 -0000 Received: from unknown (HELO thephantoms.co.uk) (176.126.243.54) by pb1.pair.com with SMTP; 19 Jun 2019 10:28:57 -0000 Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=exussum.co.uk; s=default; x=1561535013; h=Comment: DomainKey-Signature:Received:To:Subject:MIME-Version: Content-Type:Content-Transfer-Encoding:Date:From:Cc:In-Reply-To: References:Message-ID:User-Agent; bh=RRYY4Vv7487/Iqy0FKo40ZV5Twg m4NgSsj+rLwUMASM=; b=j0D/08n078Dm4wMtaX3ft/gsuP/p8ez6VJHZhZ5HJlk nGc0SmuCbNyELJksE5lzfG0+LS1xM//9ijU+v1hNF+OJesKnM5rPahZmknsb5OdT XvkEfxrCFY008DuBA8qaik2AeFXH4sm5pk4l12vP7v02FGtpgGgllHZVkeUCxD/0 = Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=exussum.co.uk; h=Received:To:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:Cc:In-Reply-To:References:Message-ID:X-Sender:User-Agent; b=Mi8lUo3PoPb5pP2xekGa2Aa4MFM5zcxbtKXMW94PUI1NV2NYxrZ5yT71CDyTsF 3KPUtSo7qLSh0rboEXqIWxjEBVLRU+5gxISQNBTai5P7q8DvYt0K02P5ioX9cQSr hhWtSLCrvTxOAQKTrhm17siByPFqj8a1Jk+rn98OUkHZk=; Received: (qmail 20489 invoked by uid 48); 19 Jun 2019 07:43:33 -0000 To: Joe Watkins MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 19 Jun 2019 08:43:33 +0100 Cc: PHP internals In-Reply-To: References: Message-ID: X-Sender: scott@exussum.co.uk User-Agent: RoundCube Webmail/0.1 Subject: Re: [PHP-DEV] [RFC] [Vote] Base convert changes From: scott@exussum.co.uk (Scott Dutton) Hi Joe, I will take a look at conflicts. The failures are extreme value checks which are a result of allowing the negative numbers. If the negative numbers one passes I will fix all tests and add some more for the negative values. The tests fail because of the unsigned -> signed change (but as you say there were quite a lot of tests). Would it be easier for 2 prs ? one for each vote ? Thanks Scott On 19.06.2019 08:31, Joe Watkins wrote: > The implementation of this does not look ready, there are conflicts > so I can't test it locally, but last time CI ran there were many > failures. > > Cheers > Joe > > On Wed, 19 Jun 2019 at 09:24, Scott Dutton > wrote: > >> Hi all >> >> I have put my RFC base convert changes to vote this morning >> >> https://wiki.php.net/rfc/base_convert_improvements [1] >> >> Two votes, one to raise a deprecated error in PHP7.4 (raised to >> exception in PHP 8) when base_convert encounters something it doesnt >> know how to convert. >> >> Second vote is to allow negative numbers, eg base_convert('-FF', 16, >> 10) would return -255 (this returns 255 currently) >> >> Voting ends 3rd July >> >> Thanks >> >> Scott >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php [2] > > > Links: > ------ > [1] https://wiki.php.net/rfc/base_convert_improvements > [2] http://www.php.net/unsub.php