Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105974
MIME-Version: 1.0
References: <CAF+90c__85rwDJ49K5=-wNV_SbSwm7z+VuKPU4Jmkuuqg5mySw@mail.gmail.com>
 <CALKiJKoWX1AOVpGfyRG85Enzf2KhQty4RRXP=WKk90PBwcLviQ@mail.gmail.com>
In-Reply-To: <CALKiJKoWX1AOVpGfyRG85Enzf2KhQty4RRXP=WKk90PBwcLviQ@mail.gmail.com>
Date: Tue, 18 Jun 2019 19:53:48 +0200
Message-ID: <CAF+90c-eneLAym+qLvp-ZYbnxWopT2PQGWOENdQWMjcgJO+XYQ@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000068a2db058b9ccc68"
Subject: Re: [PHP-DEV] Generating arginfo from stub files
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000068a2db058b9ccc68
Content-Type: text/plain; charset="UTF-8"

On Tue, Jun 18, 2019 at 7:38 PM Rowan Collins <rowan.collins@gmail.com>
wrote:

> Hi Nikita,
>
> On Tue, 18 Jun 2019 at 16:10, Nikita Popov <nikita.ppv@gmail.com> wrote:
>
>> I've created a proof of concept implementation for this at
>> https://github.com/php/php-src/pull/4284. Function signatures are
>> specified
>> in a xyz.stub.php file from which xyz_arginfo.h is generated. This file
>> can
>> then be included in the implementation. Nothing about the arginfo
>> implementation itself changes.
>>
>
>
> I notice on the PR there was discussion of stubs elsewhere (e.g.
> https://github.com/JetBrains/phpstorm-stubs) still being necessary
> because they contain additional documentation. However, has the opposite
> been considered: process an existing set of stubs to remove unsupported or
> irrelevant annotations, and import into php-src with this tool? That way,
> the manual effort for existing functions would be virtually zero.
>

This is not really possible, because we need completely accurate type
information. phpstorm-stubs is a good approximation especially when it
comes to "useful" return types, but it doesn't model things like possible
"false" return values with sufficient accuracy. Any type information we add
in php-src needs a careful review against the implementation.

Nikita

--00000000000068a2db058b9ccc68--