Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105973
MIME-Version: 1.0
References: <CAF+90c__85rwDJ49K5=-wNV_SbSwm7z+VuKPU4Jmkuuqg5mySw@mail.gmail.com>
In-Reply-To: <CAF+90c__85rwDJ49K5=-wNV_SbSwm7z+VuKPU4Jmkuuqg5mySw@mail.gmail.com>
Date: Tue, 18 Jun 2019 18:38:24 +0100
Message-ID: <CALKiJKoWX1AOVpGfyRG85Enzf2KhQty4RRXP=WKk90PBwcLviQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000000f3307058b9c9527"
Subject: Re: [PHP-DEV] Generating arginfo from stub files
From: rowan.collins@gmail.com (Rowan Collins)

--0000000000000f3307058b9c9527
Content-Type: text/plain; charset="UTF-8"

Hi Nikita,

On Tue, 18 Jun 2019 at 16:10, Nikita Popov <nikita.ppv@gmail.com> wrote:

> I've created a proof of concept implementation for this at
> https://github.com/php/php-src/pull/4284. Function signatures are
> specified
> in a xyz.stub.php file from which xyz_arginfo.h is generated. This file can
> then be included in the implementation. Nothing about the arginfo
> implementation itself changes.
>


I notice on the PR there was discussion of stubs elsewhere (e.g.
https://github.com/JetBrains/phpstorm-stubs) still being necessary because
they contain additional documentation. However, has the opposite been
considered: process an existing set of stubs to remove unsupported or
irrelevant annotations, and import into php-src with this tool? That way,
the manual effort for existing functions would be virtually zero.

Regards,
-- 
Rowan Collins
[IMSoP]

--0000000000000f3307058b9c9527--