Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105958
MIME-Version: 1.0
Date: Mon, 17 Jun 2019 14:58:26 +0200
Message-ID: <CAOWwgp=nz8KhYgWpVYK_HKtOjZsFcaryHi0_eK8kFjrZLTpvRw@mail.gmail.com>
To: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000fbe630058b848dbd"
Subject: Preloading experiments with Symfony
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000fbe630058b848dbd
Content-Type: text/plain; charset="UTF-8"

Hello,

I experimented with preload on a small Symfony app. I have two segfaults on
my patch to make it work, reported here:
https://bugs.php.net/bug.php?id=78175

I also opened https://bugs.php.net/bug.php?id=78169 but were asked to raise
the point on the list:

When opcache.preload is used, requiring twice a file that declares a
preloaded class will not yield any error, while when preloading is not
used, one will get a cannot redeclare error.

On the other side, when require_once is used, a preloaded class file is not
considered "already loaded", which means the require happens during
execution.

Would it make sense to change both these behaviors to make them more in
line with normal engine behavior? i.e. "require_once" on a file that was
already preloaded wouldn't require it again,
and "require" on a preloaded file that contains a class declaration would
yield a "cannot redeclare" fatal error?

This would be more expected to me.
Would it be possible?

Thanks,
Nicolas

--000000000000fbe630058b848dbd--