Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105957 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 14415 invoked from network); 17 Jun 2019 15:41:09 -0000 Received: from unknown (HELO mail-lj1-f181.google.com) (209.85.208.181) by pb1.pair.com with SMTP; 17 Jun 2019 15:41:09 -0000 Received: by mail-lj1-f181.google.com with SMTP id a21so9175006ljh.7 for ; Mon, 17 Jun 2019 05:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=4/M3nSwNh6UPO1P/x+0FyK0vHmkj0ITAkVpqpvLdq+M=; b=F4VMBy9HavkpcUjeicSvdXuv9usrp2X+QUoSN8t+FN1fJhAevGoLIHu6BW+sQ6SJVc 3LDWYPlUUTQMxwu6W4QltO0wGgZBmG/Psyza803+H31B9FTqn7qbD+94tZvmiLHS2kBd qgIv6uNIXiFtUMONJD4qyLxfVS7qrrqkddDO4J50M6ByDVEZIlYx8QyFvzabzcJJ4eFT 4XK7qgpd7VMgyjv0rfrQE6hrPEHvW4tdgLd/nN1bPcwRRFLv4aQ2KF7Dm3TMNcvzKL03 HII+9z5poQzDavKQfBbwur77qS8mpcsEzgsmnO5qecEly7E1qwahua6V5PqjAboYK4st EX4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=4/M3nSwNh6UPO1P/x+0FyK0vHmkj0ITAkVpqpvLdq+M=; b=NwW/DqqaTNbpwJEJQz0HDaS26/7nZ27BXn+1UmBtdd4C0LyRNbY3k2zrH9LlJdcbAK Iv0ecsVNjCS9c0/ia824+fSMo6+8WlBgb/JkYefsppG+wJbhQBFZzExtjar4T4D0/gjY vXQVdU+aqnbp+fc13MXWMKuYRPKaQramewrwKVVB21bNOOxtz70ndR8HEcnFjz52UzHH aMWLOd55X/p3/DjKq7tlJNxzU34H7q3uUHWZKcU/bQv3SP5uug1uW2IROSlcuSWyibgl ZFBj8PcFvzkR6ur0JX5dwswBSUZAiKqyhvkMEF5DzgitMFEQtaYojecqczqpiK/SihiH IMHg== X-Gm-Message-State: APjAAAVto/rmXfgCyxiMr2NMLRZJNhleEnGBQENsJTg68Mqu46Lwivdr xkjIv5XEPylYxuShQJabKg23GQs4Yz67mDwpx0bnCfJnF3A= X-Google-Smtp-Source: APXvYqxCLRyaxOc60FCZM900bI7BHW3T4pWI6lk7YJRXsXA1DVyVRUu+T5fnyBT7+kVYyrXDrcKkH4zcJDBfxB5GPR4= X-Received: by 2002:a2e:9685:: with SMTP id q5mr11055517lji.227.1560776116714; Mon, 17 Jun 2019 05:55:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Mon, 17 Jun 2019 14:54:59 +0200 Message-ID: To: PHP internals Content-Type: multipart/alternative; boundary="00000000000002beb2058b848209" Subject: Re: Disabling arginfo argument type checks for internal functions From: nikita.ppv@gmail.com (Nikita Popov) --00000000000002beb2058b848209 Content-Type: text/plain; charset="UTF-8" On Thu, Jun 6, 2019 at 2:41 PM Nikita Popov wrote: > Hi internals, > > I plan to disable the checking of arginfo argument types for internal > functions in https://github.com/php/php-src/pull/4232 (PHP 8 only). This > is necessary to avoid duplicate type checks in both arginfo and zpp. Once > this lands, PRs to add arginfo types (available through reflection) to > internal functions will be accepted. > > As a sanity check, debug builds will make sure that the function call > either throws or passes arginfo type checks -- this will help avoid the > additional of arginfo types that are not correct enforced by the > implementation. > These changes have now landed. This means that arginfo types (both argument and return) can now be added to internal functions. See https://github.com/php/php-src/commit/227a9c75ec01800cb2b02d58ab74ec72abccf478 for a small sample. PRs are welcome :) Nikita --00000000000002beb2058b848209--