Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105927
MIME-Version: 1.0
References: <CAFPFaMJ8DqBgALHLE26fu1H5eqmQuRKbUpyV_0i4_1WbtYX==Q@mail.gmail.com>
 <CAEYWF=4H2X=utR0214bhzWtVMbmS_-OXPxgA1MazTaMtfo5z-g@mail.gmail.com> <CAFPFaMKHAWRouE8RL9vaHc-E3BTv-5xk9yX=-eZYuhMUY2-BGw@mail.gmail.com>
In-Reply-To: <CAFPFaMKHAWRouE8RL9vaHc-E3BTv-5xk9yX=-eZYuhMUY2-BGw@mail.gmail.com>
Reply-To: bishop@php.net
Date: Fri, 14 Jun 2019 11:27:50 -0400
Message-ID: <CAEYWF=7m50SBRrPJseqOWkJOCdzWsso4DCHN4DFQVEJ7N3QhhA@mail.gmail.com>
To: "G. P. B." <george.banyard@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009a583d058b4a4b03"
Subject: Re: [PHP-DEV] Feedback on state of some PHP extensions, functions, etc.
From: bishop@php.net (Bishop Bettini)

--0000000000009a583d058b4a4b03
Content-Type: text/plain; charset="UTF-8"

On Fri, Jun 14, 2019 at 8:15 AM G. P. B. <george.banyard@gmail.com> wrote:

> On Wed, 12 Jun 2019 at 18:16, Bishop Bettini <bishop@php.net> wrote:
>
> > On Wed, Jun 12, 2019 at 11:35 AM G. P. B. <george.banyard@gmail.com>
> > wrote:
> >
> >>    - PharData::setAlias, PharData::setDefaultStub and  PharData::setStub
> >>    always throw PharException
> >>    <https://www.php.net/manual/en/class.pharexception.php> [11] [12]
> [13]
> >> [11] https://www.php.net/manual/en/phardata.setalias.php
> >> [12] https://www.php.net/manual/en/phardata.setdefaultstub.php
> >> [13] https://www.php.net/manual/en/phardata.setstub.php
> >
> >
> > I don't know how much this is used in the wild, but these methods exist
> so
> > that a user may treat a Phar and a PharData as interface-equivalent
> objects
> > independent of the phar.readonly INI setting. I lean toward leaving these
> > no-op methods as is, but I am happy to further discuss their merit.
> >
>
> This does make sense, liek said I was just going thought the doc and didn't
> try to see the bigger picture especially as I don't use Phar at all.
> Would it make sense to create an interface PharStream (or something else)
> on which both these object inherit? If this doesn't make sense please
> ignore me.
>

Sure, possibly. I've added this conversation to the related PHP Bug #69196
https://bugs.php.net/bug.php?id=69196

--0000000000009a583d058b4a4b03--