Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105913
To: Joe Watkins <krakjoe@gmail.com>, Derick Rethans <derick@php.net>
CC: PHP Developers Mailing List <internals@lists.php.net>
Thread-Topic: commit 374f76998 causes getenv to be define with Xdebug loaded
Thread-Index: AQHVIUlC1oHvOPVowkCx2AIIaOhEqaaYWZkAgAGVaEQ=
Date: Thu, 13 Jun 2019 18:50:29 +0000
Message-ID:
 <MN2PR02MB5775A3667F32749223C40AE4BFEF0@MN2PR02MB5775.namprd02.prod.outlook.com>
References:
 <alpine.DEB.2.21.1906121900110.10909@singlemalt.home.derickrethans.nl>,<CAOwTYAvzMC8KTw9tKbVbFDP89neNwS_d9fZgvwC_1OYqAvrdrQ@mail.gmail.com>
In-Reply-To:
 <CAOwTYAvzMC8KTw9tKbVbFDP89neNwS_d9fZgvwC_1OYqAvrdrQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
Content-Type: multipart/alternative;
	boundary="_000_MN2PR02MB5775A3667F32749223C40AE4BFEF0MN2PR02MB5775namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: da8f3b59-c701-42a8-0369-08d6f030018f
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2019 18:50:29.3440
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dmitry.stogov@roguewave.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6448
Subject: Re: commit 374f76998 causes getenv to be define with Xdebug loaded
From: dmitry@zend.com (Dmitry Stogov)

--_000_MN2PR02MB5775A3667F32749223C40AE4BFEF0MN2PR02MB5775namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

I'll try to check what was wrong with this commit and xdebug.


Thanks. Dmitry.

________________________________
From: Joe Watkins <krakjoe@gmail.com>
Sent: Wednesday, June 12, 2019 9:38:54 PM
To: Derick Rethans
Cc: Dmitry Stogov; PHP Developers Mailing List
Subject: Re: commit 374f76998 causes getenv to be define with Xdebug loaded

Hi all,

My clumsy ass reverted that in PHP-7.4, totally and utterly by accident, an=
d since it resolved Dericks problem, I went ahead and reverted in master al=
so rather than make maybe unnecessary noise.

Very very sorry about that, I totally intended to get Dmitry's approval/opi=
nion.

Terrible form, I'm sorry, I just pushed in the wrong shell.

If the revert is terrible, feel free to shout at me and revert the revert.

Cheers
Joe

On Wed, 12 Jun 2019 at 20:04, Derick Rethans <derick@php.net<mailto:derick@=
php.net>> wrote:
Hi Dmitry,

I've just fetch the latest PHP-7.4 source from GIT to finalise Xdebug
support for it, and after compiling PHP and Xdebug, I now run into the
following error:

Warning: define() expects at least 2 parameters, 1 given in
/home/derick/dev/php/derickr-xdebug/run-xdebug-tests.php on line 2749

Line 2749 is not using define, and instead is:
    $JUNIT =3D getenv('TEST_PHP_JUNIT');

I have tracked this down with git bisect to be this commit:
        https://github.com/php/php-src/commit/374f76998

Could you have a look and let me know what's up? Joe suggests that this
might need reverting.

cheers,
Derick

--
https://derickrethans.nl | https://xdebug.org | https://dram.io
Like Xdebug? Consider a donation: https://xdebug.org/donate.php,
or become my Patron: https://www.patreon.com/derickr
twitter: @derickr and @xdebug

--_000_MN2PR02MB5775A3667F32749223C40AE4BFEF0MN2PR02MB5775namp_--