Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105885
MIME-Version: 1.0
References: <alpine.DEB.2.21.1906121900110.10909@singlemalt.home.derickrethans.nl>
In-Reply-To: <alpine.DEB.2.21.1906121900110.10909@singlemalt.home.derickrethans.nl>
Date: Wed, 12 Jun 2019 20:38:54 +0200
Message-ID: <CAOwTYAvzMC8KTw9tKbVbFDP89neNwS_d9fZgvwC_1OYqAvrdrQ@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Dmitry Stogov <dmitry@zend.com>, PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000067bab4058b24ba12"
Subject: Re: commit 374f76998 causes getenv to be define with Xdebug loaded
From: krakjoe@gmail.com (Joe Watkins)

--00000000000067bab4058b24ba12
Content-Type: text/plain; charset="UTF-8"

Hi all,

My clumsy ass reverted that in PHP-7.4, totally and utterly by accident,
and since it resolved Dericks problem, I went ahead and reverted in master
also rather than make maybe unnecessary noise.

Very very sorry about that, I totally intended to get Dmitry's
approval/opinion.

Terrible form, I'm sorry, I just pushed in the wrong shell.

If the revert is terrible, feel free to shout at me and revert the revert.

Cheers
Joe

On Wed, 12 Jun 2019 at 20:04, Derick Rethans <derick@php.net> wrote:

> Hi Dmitry,
>
> I've just fetch the latest PHP-7.4 source from GIT to finalise Xdebug
> support for it, and after compiling PHP and Xdebug, I now run into the
> following error:
>
> Warning: define() expects at least 2 parameters, 1 given in
> /home/derick/dev/php/derickr-xdebug/run-xdebug-tests.php on line 2749
>
> Line 2749 is not using define, and instead is:
>     $JUNIT = getenv('TEST_PHP_JUNIT');
>
> I have tracked this down with git bisect to be this commit:
>         https://github.com/php/php-src/commit/374f76998
>
> Could you have a look and let me know what's up? Joe suggests that this
> might need reverting.
>
> cheers,
> Derick
>
> --
> https://derickrethans.nl | https://xdebug.org | https://dram.io
> Like Xdebug? Consider a donation: https://xdebug.org/donate.php,
> or become my Patron: https://www.patreon.com/derickr
> twitter: @derickr and @xdebug
>

--00000000000067bab4058b24ba12--