Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105884 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 29923 invoked from network); 12 Jun 2019 20:51:20 -0000 Received: from unknown (HELO xdebug.org) (82.113.146.227) by pb1.pair.com with SMTP; 12 Jun 2019 20:51:20 -0000 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id ED18410C884; Wed, 12 Jun 2019 19:04:16 +0100 (BST) Date: Wed, 12 Jun 2019 19:04:16 +0100 (BST) X-X-Sender: derick@singlemalt.home.derickrethans.nl To: Dmitry Stogov cc: PHP Developers Mailing List , Joe Watkins Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: commit 374f76998 causes getenv to be define with Xdebug loaded From: derick@php.net (Derick Rethans) Hi Dmitry, I've just fetch the latest PHP-7.4 source from GIT to finalise Xdebug support for it, and after compiling PHP and Xdebug, I now run into the following error: Warning: define() expects at least 2 parameters, 1 given in /home/derick/dev/php/derickr-xdebug/run-xdebug-tests.php on line 2749 Line 2749 is not using define, and instead is: $JUNIT = getenv('TEST_PHP_JUNIT'); I have tracked this down with git bisect to be this commit: https://github.com/php/php-src/commit/374f76998 Could you have a look and let me know what's up? Joe suggests that this might need reverting. cheers, Derick -- https://derickrethans.nl | https://xdebug.org | https://dram.io Like Xdebug? Consider a donation: https://xdebug.org/donate.php, or become my Patron: https://www.patreon.com/derickr twitter: @derickr and @xdebug