Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105860 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 46177 invoked from network); 7 Jun 2019 16:55:51 -0000 Received: from unknown (HELO mail-vs1-f49.google.com) (209.85.217.49) by pb1.pair.com with SMTP; 7 Jun 2019 16:55:51 -0000 Received: by mail-vs1-f49.google.com with SMTP id l125so1193912vsl.13 for ; Fri, 07 Jun 2019 07:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jPFFssGrecDMuGMD3Tk1tDlLDpB4g56tbr9OonFmYL4=; b=ksI8oa+W7HcmO+xRhvCcc0XEMlRRNB5o+pYorLJ6+KRGafLT/gCS1sYbP/S8zx2agt 7ExtE20WWQNp6CdUechVUM7rFg5o18FuGClJSU94xEUNRLdg2qpqpGrqjNMHTqo9v26F QY7gDmESEa0teEsMqCbo8hbSwV38y3SnVcYXJ9LVhYSfHJ7ZVw/H4n5T+zP+VPX7zwzW mTcDmQjso+ipmklTblw3piGXKI2Q+p6B0HvidB8mWF/OW9m4NwDlMVLuZrJ8lVSykXpc 6lxmvifTAfyytPk3Kd9FKmCVOmxnn5Vv0ohRSLS+DBBtmPNKh4595EY/DVUV6JtZ5EX2 NZGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jPFFssGrecDMuGMD3Tk1tDlLDpB4g56tbr9OonFmYL4=; b=mZL4SoL6w0bc+lfImozWH9/Ch4Bxil/TFsgVqLMEFion3lXgrfdp8lKna0e71yGq95 Gulz1/WxvjOeqzBQACp4wgKTtMmdiut5DCTpiyoKvmmTMYU4m6vO6LVVJWHscWT/QyTN PGgteApfwIy3DEt8UFIROvH5ABaEZ5GzV0ApKX6MYohQItF4b2jjZ8GwFOIHwgIe3wqz zPbidPAUtYoBuBGIGq8U810EcOC7IcQy2C41iWFstz0hEjMZ5aA5irokpzfcefdxh+iR CDL7PGaj3mxX6Ha+ceaM+FMmO4G/NDCMzcpsHjEwwEx+xxkQ/3PY/WBWfh8n2QSaN41r gsgw== X-Gm-Message-State: APjAAAWVgYpBBWdFBhnwmPkb9F2y/ilGfaM0D2p45gm+2EL030gZAa8G rJoCVno9u5XdMLRgezdeUa77gppxzK/3W0yHjKw= X-Google-Smtp-Source: APXvYqyFJT76ARl+2n+ZktY0aqsmddGIlNQowsPlHNesSKxcGRyY018SMleIJjccM/jH+NplwzKHXaJA94GX5R79nOM= X-Received: by 2002:a67:d50f:: with SMTP id l15mr16487941vsj.108.1559916450869; Fri, 07 Jun 2019 07:07:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 7 Jun 2019 16:07:19 +0200 Message-ID: To: Peter Cowburn Cc: Marco Pivetta , PHP Internals List Content-Type: multipart/alternative; boundary="000000000000eef9f0058abc59e4" Subject: Re: [PHP-DEV] Using [ci skip] From: krakjoe@gmail.com (Joe Watkins) --000000000000eef9f0058abc59e4 Content-Type: text/plain; charset="UTF-8" Hi Peter, I think it's pretty well known about, but don't think we have it written down anywhere. I could make a note of it somewhere. I think in the case of azure it can be configured but I'm not sure about the others. I'll try to find out. Cheers Joe On Fri, 7 Jun 2019 at 16:00, Peter Cowburn wrote: > > > On Fri, 7 Jun 2019 at 12:09, Joe Watkins wrote: > >> Oh to be absolutely clear, I'm talking about commits that *only* touch >> these non-source files ... >> >> Cheers >> Joe >> >> On Fri, 7 Jun 2019 at 13:07, Joe Watkins wrote: >> >> > Hi Marco, >> > >> > It wasn't a topic for discussion, it was a request to committers in >> > php-src. >> > >> > We do not need to run CI for NEWS changes, and we can definitely be sure >> > it doesn't effect the build. >> > >> > The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... >> > >> > Under normal circumstances these files are not changed by themslves, but >> > occasionally, we have to correct one of these files and omitting [ci >> ski] >> > puts the build behind by up to an hour ... >> > >> > Cheers >> > Joe >> > >> > On Fri, 7 Jun 2019 at 13:02, Marco Pivetta wrote: >> > >> >> Please avoid doing that: >> >> >> >> 1. Commit messages are for humans >> >> 2. You never know what can break, that's why it's "continuous" there >> >> (besides religious views around what "continuous integration" means) >> >> >> >> On Fri, Jun 7, 2019, 12:51 Joe Watkins wrote: >> >> >> >> > Hi all, >> >> > >> >> > Just a friendly reminder that when we're committing changes to files >> >> that >> >> > do not contain source, test code, or build configuration, it's >> helpful >> >> to >> >> > include [ci skip] in the commit message. Omitting it can put our CI >> >> quite >> >> > far behind. >> > > Is this documented somewhere? I'm not seeing it in the docs held in > php-src, nor a search of the wiki, for example. > Also, is this not something that the CI application(s) can be configured > to do for us? > > >> >> > >> >> > Cheers >> >> > Joe >> >> > >> >> >> > >> > --000000000000eef9f0058abc59e4--