Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:10586
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Fri, 18 Jun 2004 13:24:11 +0100
To: internals@lists.php.net
Message-ID: <20040618122411.GC24157@redhat.com>
Mail-Followup-To: internals@lists.php.net
References: <20040618103032.GA25820@redhat.com> <200406181413.14024.magnus@php.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <200406181413.14024.magnus@php.net>
User-Agent: Mutt/1.4.1i
Subject: Re: [PHP-DEV] [PATCH] apache2handler memory leak fix
From: jorton@redhat.com (Joe Orton)

On Fri, Jun 18, 2004 at 02:13:05PM +0200, Magnus Määttä wrote:
> Hi!
> 
> On Friday 18 June 2004 12.30, Joe Orton wrote:
> > It's simpler to just use the ap_r* interfaces in the the handler SAPI
> > for 2.0, this improves network usage by allowing httpd to buffer as
> > necessary, and fixes a bug where ub_write is unnecessarily pmemdup'ing
> > the string (it could have used a transient bucket to avoid that; the
> > apache2filter got this right), and stops re-using an output brigade
> > which is now or at least will soon be a 2.0 API violation.
> >
> > (this restores constant memory use for an arbitrary length response)
> 
> I've attached a forward port of this patch for HEAD.
> This also fixes bug #28113.

Ah, thanks Magnus.  Note that flush() may still leak a small amount of
memory but this is what I'm working to fix in httpd.

Regards,

joe