Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105859
MIME-Version: 1.0
References: <CAOwTYAsLeE8MijU5b8BMTJiJ1r+bKa-g6tAqYyB52o+Zp3VQHw@mail.gmail.com>
 <CADyq6s+XtpjKgd0+DKEpT=AxiY31BFif-qyd7c5BiL1_kcFnRA@mail.gmail.com>
 <CAOwTYAsxrjCqWYEsj6aZkR0YY9a-DoNzXi4Q_x=NVWkyusnqGg@mail.gmail.com>
 <CAOwTYAucSEnOJexgSVsR6MAScHL1Diwh11QeODeWEReH5ZV2XA@mail.gmail.com> <CAPg3Xx+--Q+nZBdhiPcx7yuqS8NxQN3W0b7EtiedzE4soEq3TA@mail.gmail.com>
In-Reply-To: <CAPg3Xx+--Q+nZBdhiPcx7yuqS8NxQN3W0b7EtiedzE4soEq3TA@mail.gmail.com>
Date: Fri, 7 Jun 2019 16:06:25 +0200
Message-ID: <CAF+90c8V2_NiknfffP2QAcEY2TiA1EHJ15xGvdMnJDwqDZKaKA@mail.gmail.com>
To: Peter Cowburn <petercowburn@gmail.com>
Cc: Joe Watkins <krakjoe@gmail.com>, Marco Pivetta <ocramius@gmail.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000070d11058abc57bc"
Subject: Re: [PHP-DEV] Using [ci skip]
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000070d11058abc57bc
Content-Type: text/plain; charset="UTF-8"

On Fri, Jun 7, 2019 at 4:01 PM Peter Cowburn <petercowburn@gmail.com> wrote:

> On Fri, 7 Jun 2019 at 12:09, Joe Watkins <krakjoe@gmail.com> wrote:
>
> > Oh to be absolutely clear, I'm talking about commits that *only* touch
> > these non-source files ...
> >
> > Cheers
> > Joe
> >
> > On Fri, 7 Jun 2019 at 13:07, Joe Watkins <krakjoe@gmail.com> wrote:
> >
> > > Hi Marco,
> > >
> > > It wasn't a topic for discussion, it was a request to committers in
> > > php-src.
> > >
> > > We do not need to run CI for NEWS changes, and we can definitely be
> sure
> > > it doesn't effect the build.
> > >
> > > The same goes for other files like UPGRADING, UPGRADING.INTERNALS ...
> > >
> > > Under normal circumstances these files are not changed by themslves,
> but
> > > occasionally, we have to correct one of these files and omitting [ci
> ski]
> > > puts the build behind by up to an hour ...
> > >
> > > Cheers
> > > Joe
> > >
> > > On Fri, 7 Jun 2019 at 13:02, Marco Pivetta <ocramius@gmail.com> wrote:
> > >
> > >> Please avoid doing that:
> > >>
> > >>  1. Commit messages are for humans
> > >>  2. You never know what can break, that's why it's "continuous" there
> > >> (besides religious views around what "continuous integration" means)
> > >>
> > >> On Fri, Jun 7, 2019, 12:51 Joe Watkins <krakjoe@php.net> wrote:
> > >>
> > >> > Hi all,
> > >> >
> > >> > Just a friendly reminder that when we're committing changes to files
> > >> that
> > >> > do not contain source, test code, or build configuration, it's
> helpful
> > >> to
> > >> > include [ci skip] in the commit message. Omitting it can put our CI
> > >> quite
> > >> > far behind.
> >
>
> Is this documented somewhere? I'm not seeing it in the docs held in
> php-src, nor a search of the wiki, for example.
> Also, is this not something that the CI application(s) can be configured to
> do for us?
>

That's a good point. It looks like the option exists:
https://docs.microsoft.com/en-us/azure/devops/pipelines/build/triggers?view=azure-devops&tabs=yaml#paths

I think we used something like this on AppVeyor at some time, but had to
disable it for some reason (?)

Nikita

--000000000000070d11058abc57bc--