Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105857
MIME-Version: 1.0
References: <CAOwTYAsLeE8MijU5b8BMTJiJ1r+bKa-g6tAqYyB52o+Zp3VQHw@mail.gmail.com>
 <CADyq6s+XtpjKgd0+DKEpT=AxiY31BFif-qyd7c5BiL1_kcFnRA@mail.gmail.com> <CAOwTYAsxrjCqWYEsj6aZkR0YY9a-DoNzXi4Q_x=NVWkyusnqGg@mail.gmail.com>
In-Reply-To: <CAOwTYAsxrjCqWYEsj6aZkR0YY9a-DoNzXi4Q_x=NVWkyusnqGg@mail.gmail.com>
Date: Fri, 7 Jun 2019 13:09:00 +0200
Message-ID: <CAOwTYAucSEnOJexgSVsR6MAScHL1Diwh11QeODeWEReH5ZV2XA@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002ce884058ab9dcf2"
Subject: Re: [PHP-DEV] Using [ci skip]
From: krakjoe@gmail.com (Joe Watkins)

--0000000000002ce884058ab9dcf2
Content-Type: text/plain; charset="UTF-8"

Oh to be absolutely clear, I'm talking about commits that *only* touch
these non-source files ...

Cheers
Joe

On Fri, 7 Jun 2019 at 13:07, Joe Watkins <krakjoe@gmail.com> wrote:

> Hi Marco,
>
> It wasn't a topic for discussion, it was a request to committers in
> php-src.
>
> We do not need to run CI for NEWS changes, and we can definitely be sure
> it doesn't effect the build.
>
> The same goes for other files like UPGRADING, UPGRADING.INTERNALS ...
>
> Under normal circumstances these files are not changed by themslves, but
> occasionally, we have to correct one of these files and omitting [ci ski]
> puts the build behind by up to an hour ...
>
> Cheers
> Joe
>
> On Fri, 7 Jun 2019 at 13:02, Marco Pivetta <ocramius@gmail.com> wrote:
>
>> Please avoid doing that:
>>
>>  1. Commit messages are for humans
>>  2. You never know what can break, that's why it's "continuous" there
>> (besides religious views around what "continuous integration" means)
>>
>> On Fri, Jun 7, 2019, 12:51 Joe Watkins <krakjoe@php.net> wrote:
>>
>> > Hi all,
>> >
>> > Just a friendly reminder that when we're committing changes to files
>> that
>> > do not contain source, test code, or build configuration, it's helpful
>> to
>> > include [ci skip] in the commit message. Omitting it can put our CI
>> quite
>> > far behind.
>> >
>> > Cheers
>> > Joe
>> >
>>
>

--0000000000002ce884058ab9dcf2--