Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105856 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 84929 invoked from network); 7 Jun 2019 13:56:12 -0000 Received: from unknown (HELO mail-vs1-f41.google.com) (209.85.217.41) by pb1.pair.com with SMTP; 7 Jun 2019 13:56:12 -0000 Received: by mail-vs1-f41.google.com with SMTP id l20so906483vsp.3 for ; Fri, 07 Jun 2019 04:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PCYFr5XmoLWv2Ol/e/L+fzkUnQQMOWBWysp1ZkjOFAU=; b=o+bDWA2iUhkEBm+/+6II92n/vcQUZWCZew0ObkkTLnXoX/2EhBWhC2vLiaCZ96XoNT xsOGzZPhSn+J0yD3RsJaTuKe0JZqj3n7/uthRYjuHkB6TxHNw7P1a5COrGkay0dRf326 NG5bTmSKtq7Sqw7YRCKnrVS2Fg8/8AeFVnWzdMMXmVIUKBJZ4vCAK1qRCSxeg4A/qKbQ /O5NTMEaaW0AZC2OjFPwyYbGZFRuVpHKgsrZVhyAONzJ4i1nZljlqsfm+ekoU9b9drI+ I6wMPTp0psyiqk8WN4V2H49L0guvFPG+bNUjGwNuej7O64qvdULprK0SAI5/cy4Dx3o2 Gbig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PCYFr5XmoLWv2Ol/e/L+fzkUnQQMOWBWysp1ZkjOFAU=; b=CZEWnAPFIAtilQkfktcoP95EO1QGs1Pktt3di1oOGUj6ua+HxJbrg/TodnxWRF4OBd aryBSpoJYl9k0z6JLVV377rWiOINFaeZsZ9JEo+H2q3m28PghNugK/Y5OeZGET5yPp5Q 7D4AI4QWv9IlTNDfj3cyRh+DhC4/aZB3ALcv22+PXe6sR/Abhicz92iHtNh32coIjeEL Cghl6oTVMldcrSqATEwsWZX0F7/h4z7VPaWXllUCtzP6tB7aFYNbvMiro6mXx9Yg4iT5 GaI346lZYPRbs7TIq3spJnSWxxOdZuOtPY4Pkl34+ROVXu0jyK0Ui7s7IVU59ZwYU1rR szBQ== X-Gm-Message-State: APjAAAUwtG5hqQO+RC7pigptyPW+hw9U4dcXCep/n3hDlBMVa00PE73k e6TBjMmIyZdrxZrGTbhwk39DQU3Hv2Nkqr11U7w= X-Google-Smtp-Source: APXvYqwwzuVMWJ3O3Vxlb2mr8R1S0ElWMPI5VBVaKvDtakRrBxoNUIKPx1ZcNRFADuzB1/WSr4tfkFMscUDa8jkvdao= X-Received: by 2002:a67:eb0a:: with SMTP id a10mr26729694vso.42.1559905670417; Fri, 07 Jun 2019 04:07:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 7 Jun 2019 13:07:39 +0200 Message-ID: To: Marco Pivetta Cc: PHP Internals List Content-Type: multipart/alternative; boundary="0000000000005e50e2058ab9d7e4" Subject: Re: [PHP-DEV] Using [ci skip] From: krakjoe@gmail.com (Joe Watkins) --0000000000005e50e2058ab9d7e4 Content-Type: text/plain; charset="UTF-8" Hi Marco, It wasn't a topic for discussion, it was a request to committers in php-src. We do not need to run CI for NEWS changes, and we can definitely be sure it doesn't effect the build. The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... Under normal circumstances these files are not changed by themslves, but occasionally, we have to correct one of these files and omitting [ci ski] puts the build behind by up to an hour ... Cheers Joe On Fri, 7 Jun 2019 at 13:02, Marco Pivetta wrote: > Please avoid doing that: > > 1. Commit messages are for humans > 2. You never know what can break, that's why it's "continuous" there > (besides religious views around what "continuous integration" means) > > On Fri, Jun 7, 2019, 12:51 Joe Watkins wrote: > > > Hi all, > > > > Just a friendly reminder that when we're committing changes to files that > > do not contain source, test code, or build configuration, it's helpful to > > include [ci skip] in the commit message. Omitting it can put our CI quite > > far behind. > > > > Cheers > > Joe > > > --0000000000005e50e2058ab9d7e4--