Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105843
MIME-Version: 1.0
References: <CAF+90c_DEpQpLe7M_g5vQZmxHD-e5fEyxubpH_99vhKYvkDWYA@mail.gmail.com>
 <F620A9B4-C930-4855-82D0-F9EF9896253B@gmail.com> <CAG9XoMQLKHv6s79yMRd2SDWEoFCxy+wsbJG+AZ7Hjx+OXZwbSw@mail.gmail.com>
 <CADyq6s+2Gju9aXHX2T70wpNXhL9ALVS+JdLPY1hkF-WNjik1xA@mail.gmail.com> <CAF+90c9qoQ677y1GHtbZMYsBpmAqHbUqeq0K6RGzN1vVbQqwKA@mail.gmail.com>
In-Reply-To: <CAF+90c9qoQ677y1GHtbZMYsBpmAqHbUqeq0K6RGzN1vVbQqwKA@mail.gmail.com>
Date: Thu, 6 Jun 2019 09:52:57 +0200
Message-ID: <CAF+90c-UYn1mPaK_0qX=4hoSayrLn_wsxT8qZY-pKV0EDjrKaw@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Benjamin Morel <benjamin.morel@gmail.com>, Steven Wade <stevenwadejr@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a4ccbb058aa30151"
Subject: Re: [PHP-DEV] Add get_mangled_object_properties()
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000a4ccbb058aa30151
Content-Type: text/plain; charset="UTF-8"

On Tue, May 14, 2019 at 4:45 PM Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Tue, May 14, 2019 at 4:37 PM Marco Pivetta <ocramius@gmail.com> wrote:
>
>>
>> On Tue, May 14, 2019 at 4:29 PM Benjamin Morel <benjamin.morel@gmail.com>
>> wrote:
>>
>>> I like the explicitness of the proposal, but only if performance is as
>>> good
>>> as (array) cast. One of the reasons we use casting to array in libraries
>>> is
>>> not only to access all properties at once, but also because it's fast as
>>> it's implemented as an opcode and not a function call. Would this
>>> function
>>> come with its own opcode, like strlen() / gettype() / etc.?
>>>
>>> Ben
>>>
>>
>> Indeed. Besides that, this is a good chance to have an explicit `object`
>> parameter type.
>>
>> @Nikic is the return type also `array`, according to reflection?
>>
>
> I'd prefer not to add either of them until the question of type
> annotations on internal functions is solved more comprehensively in PHP 8.
> In particular adding an "object" type will currently add additional cost to
> the call. I hope that we'll solve this problem in PHP 8 and annotate
> functions with types in a comprehensive way (including existing functions,
> like get_object_vars).
>
> Nikita
>

Any more feedback on the addition of get_mangled_object_vars()?

Regarding the typehints, I've added an "array" return type for
get_object_vars() in PHP 8 (
https://github.com/php/php-src/commit/252216b2ded7d3808e2a909bfea1e805ee17cde5)
and will do the same for this function. The argument type is still blocked
on some preparatory work.

Nikita

--000000000000a4ccbb058aa30151--