Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105838
MIME-Version: 1.0
References: <CA+kxMuS6gnPZqd-e5UV_zmE3q9ZpXS+UBSGNvF7hiagY15LFJw@mail.gmail.com>
 <5ce73302.1c69fb81.f3278.4af8SMTPIN_ADDED_MISSING@mx.google.com>
In-Reply-To: <5ce73302.1c69fb81.f3278.4af8SMTPIN_ADDED_MISSING@mx.google.com>
Date: Tue, 4 Jun 2019 21:05:47 +0200
Message-ID: <CAOWwgpmRqqC6YoUrWP_3jG2DKzz0F47epa3WE=L8GbDSaOLKmA@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d025ec058a842b89"
Subject: Re: [PHP-DEV] Re: JSON_THROW_ON_ERROR implementation detail
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000d025ec058a842b89
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Le ven. 24 mai 2019 =C3=A0 01:55, Andrea Faulds <ajf@ajf.me> a =C3=A9crit :

>
> Please see the discussion on the original pull request:
> https://github.com/php/php-src/pull/2662
>
> The existing behaviour is deliberate, was already discussed, and was
>

Symfony is affected too, could you please have a look at the following PR?
https://github.com/symfony/symfony/pull/31860/files

Is the added boilerplate correct? Is this behavior planned to change / be
fixed in the short term?
Global side effects are nightmare, that cannot be "by design".
Thanks for considering.

Hugs,
Nicolas


> part of the RFC that was accepted. So there is a high standard to meet
> for going back on that.
>
> The idea was to keep the two error handling approaches cleanly
> separated. This would mean that we could eventually change the default
> behaviour and deprecate the old error mechanism, if we wanted to.
>
> If you explicitly request the modern exception-based error-handling
> mechanism and catch the exception, which contains the error code and
> message, you have no good reason to then try to retrieve the same error
> code and message via the legacy functions. What's the advantage of
> mixing and matching interfaces like this? It doesn't feel like good
> coding practice.
>
> Sorry for the slow response. I haven't checked the internals list that
> frequently lately.
>
> Andrea
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--000000000000d025ec058a842b89--