Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105799
MIME-Version: 1.0
References: <DM5PR06MB2857D1780DEB4D81724DB48FDE090@DM5PR06MB2857.namprd06.prod.outlook.com>
 <CA+kxMuTtSkROORRdGmNtkiFqe1FM6BKzScaxOVBzQUKBZHnVzg@mail.gmail.com>
 <e9eefc7d-45a4-3b47-15a2-4d6b57097460@gmail.com> <1858501.VmE1D5L3rF@mcmic-probook>
 <39e8e5ad-6685-9406-68ac-1fb1edbeb537@fischer.name> <CAGa2bXaa3rHJX7SfrmR7sDRWVGNetLz=Tz5O8gKHsRRzUHdA8Q@mail.gmail.com>
 <CAFPFaMKusFyVr+=sMzOv8utepk8ip=GPiXyF+8_cH=U8Gio78A@mail.gmail.com>
In-Reply-To: <CAFPFaMKusFyVr+=sMzOv8utepk8ip=GPiXyF+8_cH=U8Gio78A@mail.gmail.com>
Date: Wed, 29 May 2019 19:33:57 +0100
Message-ID: <CA+kxMuQhO+SKJT0Bw+PrLkCHUnVYV1QRzTAkeGXzJGfi4CRm8Q@mail.gmail.com>
To: "G. P. B." <george.banyard@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Re: [RFC] Numeric Literal Separator
From: Danack@basereality.com (Dan Ackroyd)

On Wed, 29 May 2019 at 12:35, G. P. B. <george.banyard@gmail.com> wrote:
>
> Also I think those kind of magic numbers should be constants with
> meaningful names, and it that case you could just compute them by adding
> powers of ten.
> E.g. DISCOUNT_IN_CENTS = 1 * 10^5 + 3 * 10^4 + 5 * 10^3;

I agree naming things is important, but when I'm working with
non-programmers (e.g. the people in the accounts department), and we
have lots of numbers in front of us, something like:

EXAMPLE_ON_BUDGET                 = 1_000_000;
EXAMPLE_UNDER_BUDGET         = 990_000;
EXAMPLE_OVER_TARGET            = 1_001_000;
EXAMPLE_WAY_OVER_BUDGET  = 1_100_000;

is going to be way easier to read than either the version without
underscore, and definitely easier than power of ten notation.

cheers
Dan
Ack