Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105794
MIME-Version: 1.0
References: <DM5PR06MB2857D1780DEB4D81724DB48FDE090@DM5PR06MB2857.namprd06.prod.outlook.com>
 <CA+kxMuTtSkROORRdGmNtkiFqe1FM6BKzScaxOVBzQUKBZHnVzg@mail.gmail.com>
 <e9eefc7d-45a4-3b47-15a2-4d6b57097460@gmail.com> <1858501.VmE1D5L3rF@mcmic-probook>
 <39e8e5ad-6685-9406-68ac-1fb1edbeb537@fischer.name> <CAGa2bXaa3rHJX7SfrmR7sDRWVGNetLz=Tz5O8gKHsRRzUHdA8Q@mail.gmail.com>
In-Reply-To: <CAGa2bXaa3rHJX7SfrmR7sDRWVGNetLz=Tz5O8gKHsRRzUHdA8Q@mail.gmail.com>
Date: Wed, 29 May 2019 12:34:58 +0100
Message-ID: <CAFPFaMKusFyVr+=sMzOv8utepk8ip=GPiXyF+8_cH=U8Gio78A@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007a8de6058a052c25"
Subject: Re: [PHP-DEV] Re: [RFC] Numeric Literal Separator
From: george.banyard@gmail.com ("G. P. B.")

--0000000000007a8de6058a052c25
Content-Type: text/plain; charset="UTF-8"

I share the same concerns as Rowan Collins, and I'm really not a fan of the
RFC in general.
Also I think those kind of magic numbers should be constants with
meaningful names, and it that case you could just compute them by adding
powers of ten.
E.g. DISCOUNT_IN_CENTS = 1 * 10^5 + 3 * 10^4 + 5 * 10^3;
Now I'm assuming opcache would compile this into a final integer but I may
be wrong on how the internals of the engine work in this case.
Moreover I feel that people may misread numbers like that if people use
different groupings.
E.g. 1_0000_0000_0000; by skimming rapidly I could think it's a
billion(10^6) when in reality it's a trillion (10^9).
Even if maybe some countries are moving away from the grouping digits in
groups of 4.

I'll probably vote against it but that's only my opinion.

George P. Banyard

--0000000000007a8de6058a052c25--