Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105771
MIME-Version: 1.0
References: <4bdc84d133912367ab9d5139f37f9a6e@exussum.co.uk> <2ba93b339e2291b2680186726e0e32ad@exussum.co.uk>
In-Reply-To: <2ba93b339e2291b2680186726e0e32ad@exussum.co.uk>
Date: Tue, 21 May 2019 09:43:34 +0100
Message-ID: <CAFPFaMLNbyOLPwyKNLeHgH78TDkC7Yxr4M4=kiankiofMEwLqg@mail.gmail.com>
To: Scott Dutton <scott@exussum.co.uk>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e7d12a058961d80f"
Subject: Re: [PHP-DEV] [RFC] Base convert changes
From: george.banyard@gmail.com ("G. P. B.")

--000000000000e7d12a058961d80f
Content-Type: text/plain; charset="UTF-8"

On Tue, 21 May 2019, 06:42 Scott Dutton, <scott@exussum.co.uk> wrote:

>
> Not sure if I can add and example to the RFC at this point, but I came
> across another example of this recently.
>
>
> https://gist.github.com/iansltx/4820b02ab276c3306314daaa41573445#file-getlines-php-L9
>
>      // bindec() was doing weird things, hence converting through hex
> first
>      // sttrev() to match endian-ness to expectations; zip file values
> are little-endian
>      $compressedSize = hexdec(bin2hex(strrev(fread($stream, 4)))); //
> compressed size
>
> bindec was returning 0 without warning, as it was passed binary data
> not a binary string. No warning bin2hex actually does the correct
> translation.
>
> a warning here would have at least indicated there was something wrong
> with the input it was being passed instead of just 0.
>
> Thanks
>
> Scott
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php


Until the RFC is in voting you can still make amendments to it.
So feel free to add these functions/examples to the RFC.

Best regards

George Peter Banyard

--000000000000e7d12a058961d80f--