Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105753
MIME-Version: 1.0
References: <CAJW__o0yRBpNTDXYV8Ns3SoyhYHOiBZXr8jPzZ+dBUXAt0Vk9Q@mail.gmail.com>
 <1b95b6af-adc5-0f69-b277-9f7c6b30345f@gmx.de>
In-Reply-To: <1b95b6af-adc5-0f69-b277-9f7c6b30345f@gmx.de>
Date: Sun, 19 May 2019 02:56:15 +0300
Message-ID: <CAJW__o3f1Coxcc1+ZjymSnRk6aefo2VnfJ7EPUGMF2GBaoVqZQ@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: Changing the default value of SQLite3::enableExceptions()
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Christoph

Den l=C3=B8r. 18. maj 2019 kl. 13.00 skrev Christoph M. Becker <cmbecker69@=
gmx.de>:
> However, I don't think that we can change the default value in the near
> future for BC reasons.  Deprecating (7.4) and removing support (8.0) for
> calling the method without argument would be the way to go, I think.

Yeah I agree here. We could go a similar around to what you proposed
for the curl version function, something like (for PHP-7.4):

if (ZEND_NUM_ARGS() =3D=3D 0) {
   /* E_DEPRECATED: Relying on the default value of $enableExceptions
is deprecated as it will change from FALSE to TRUE ...*/
}

And for master simply making the parameter required. I suspect the
impact of this is very minimal as most users of this would not be
affected by this proposal unless its a bug in their code (as I don't
expect anyone to call ->enableExceptions() to *disable* them being
anything but a bug).

> [In a somewhat distant future, we might consider reintroducing support
> for argument-less calls, but in this case it might make sense to let the
> method work as getter (i.e. without argument, it would return the
> current value without changing it).]

Currently SQLite3::enableExceptions() will return the old value, I
think we should retain this and only change the default value.


--=20
regards,

Kalle Sommer Nielsen
kalle@php.net