Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105752
MIME-Version: 1.0
References: <CAJW__o0yRBpNTDXYV8Ns3SoyhYHOiBZXr8jPzZ+dBUXAt0Vk9Q@mail.gmail.com>
 <CAMERU+7=UkEZ3Ej-MZG4ZM+ZN2x7dh_Hx6kVmOLSCJLMFaOM2g@mail.gmail.com>
In-Reply-To: <CAMERU+7=UkEZ3Ej-MZG4ZM+ZN2x7dh_Hx6kVmOLSCJLMFaOM2g@mail.gmail.com>
Date: Sun, 19 May 2019 02:47:01 +0300
Message-ID: <CAJW__o0bMCG3dZQi6NtJGE5AyRkuEox_kGsOt59ovOSCVKUm8A@mail.gmail.com>
To: Robert Kopack <rkopack@tenable.com>
Cc: Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Changing the default value of SQLite3::enableExceptions()
From: kalle@php.net (Kalle Sommer Nielsen)

Hi

Den fre. 17. maj 2019 kl. 23.20 skrev Robert Kopack <rkopack@tenable.com>:
>
> I feel like changing the default value of $enableExceptions to TRUE
> makes more sense since that is what you would expect from the original
> function call as it stands and is the least breakage of anything
> already existing (since making it a required variable would throw
> ArgumentCountError for any existing code).
>
> WRT the PR you mentioned (since it's my own), do you think it would be
> better to change the current toggleExtendedResultCodes to
> enableExtendedResultCodes and have a similar function prototype to
> enableExceptions? I didn't consider that when I wrote my changes (to
> be honest I don't use the sqlite3 class directly so I didn't know
> about it, I only used the pdo_sqlite layer above it).

I thought about proposing that, but I wanted to run this issue by
internals first to hear others thoughts on the matter. I definitely
think consistency is something we should embrace more and thinking
about it for a day then I do think we should keep the naming similar,
but avoid a design like SQLite3::enableExceptions().

-- 
regards,

Kalle Sommer Nielsen
kalle@php.net