Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105721
To: Robert Kopack <rkopack@tenable.com>, internals@lists.php.net
References: <CAMERU+4=XQ_8oji+McTjQB2pPXFLR1D6_2iWyFxiTVLCZX3pJQ@mail.gmail.com>
Message-ID: <b7b52123-82ce-34bb-9ebf-365c0ac82ff3@gmx.de>
Date: Thu, 16 May 2019 00:54:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAMERU+4=XQ_8oji+McTjQB2pPXFLR1D6_2iWyFxiTVLCZX3pJQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: RFC for Sqlite3 Extended Error Codes
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 15.05.2019 at 19:14, Robert Kopack wrote:

> I would to extend the functionality of the current sqlite3 implementatio=
n
> (in *ext/sqlite3* and in *ext/pdo_sqlite*) by exposing the functions
> related to extended result codes. I have already forked and made my chan=
ges
> at
> https://github.com/rkopack/php-src/commit/f6c4d1eeccd27a3c5bd836fd8205b1=
283bd5eabc.
> From
> my understanding Scott MacVicar and Christoph M. Becker are the primary
> maintainers for the sqlite3 extension and Ilia Alshanetsky is the primar=
y
> maintainer for the pdo_sqlite extension;

It's best to look at EXTENSIONS in master[1], which also reveals the
most up-to-date dates of maintainership =E2=80=93 i.e. pdo_sqlite is effec=
tively
maintained by the core maintainers.

> if any of you would like to
> comment on this (it's around 50 lines of new code) so I can get feedback=
 on
> this I would greatly appreciate it. I made sure to follow the convention=
 I
> saw in the file(s) to the best of my ability but I am sure there are lit=
tle
> things I might have missed.

I haven't reviewed closely for now, but basically I like these
additions.  With regard to sqlite3_extended_result_codes() we have to
review existing error checks (they likely need small adjustments, if
extended error codes are enabled).  And we likely want to have a few
tests for the new functionality.

Feel free to submit a pull request[2]; it seems to me any discussion
could happen on Github as well. :)

[1] <https://github.com/php/php-src/blob/master/EXTENSIONS>
[2] <https://github.com/php/php-src/pulls>

Thanks,
Christoph