Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105696
MIME-Version: 1.0
References: <000901d4f87a$1e2421d0$5a6c6570$@jhdxr.com> <023d01d505c9$f16a2b50$d43e81f0$@jhdxr.com>
In-Reply-To: <023d01d505c9$f16a2b50$d43e81f0$@jhdxr.com>
Date: Tue, 14 May 2019 13:00:38 +0200
Message-ID: <CAF+90c_x2sOo+FiRekLbrcnhc0UxcWYBUEhinF-rr0DAK4UgPQ@mail.gmail.com>
To: CHU Zhaowei <me@jhdxr.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005d38850588d6f237"
Subject: Re: [PHP-DEV] RE: [RFC][VOTE] Spread Operator in Array Expression v0.2
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000005d38850588d6f237
Content-Type: text/plain; charset="UTF-8"

On Wed, May 8, 2019 at 8:15 PM CHU Zhaowei <me@jhdxr.com> wrote:

> Sorry for the one day delay. This RFC has passed with 43 votes in favor and
> 1 against.
>
>
>
> Thanks & Regards,
>
> CHU Zhaowei
>

I've merged the implementation for this RFC yesterday. However, I would
like to propose adding one extra restriction, implemented in
https://github.com/php/php-src/pull/4162.

Currently, the implementation allows writing things like this:

    [42 => 0, ...$array]
    ['a' => 'b', ...$array]

I think that with the current behavior of ..., where string keys are
forbidden and integer keys are reindexed, it would be best to make these
usages illegal as well, at least for the time being. Especially to avoid
tying our hands too much when it comes to adding the [$head, ...$tail] =
syntax in the future.

Nikita

--0000000000005d38850588d6f237--