Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105683
MIME-Version: 1.0
References: <CA+kxMuS6gnPZqd-e5UV_zmE3q9ZpXS+UBSGNvF7hiagY15LFJw@mail.gmail.com>
 <CAEYWF=5E+ec9mn30GQu-wr61XSQKbymr9O8Mz5CDJ-p8oCwSBA@mail.gmail.com>
In-Reply-To: <CAEYWF=5E+ec9mn30GQu-wr61XSQKbymr9O8Mz5CDJ-p8oCwSBA@mail.gmail.com>
Date: Sun, 12 May 2019 18:06:19 +0100
Message-ID: <CA+kxMuSYWrbuUWuGZ4WypmxqbDLsbMjZmvQnEX-_bS4HFTX7sA@mail.gmail.com>
To: Bishop Bettini <bishop@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] JSON_THROW_ON_ERROR implementation detail
From: Danack@basereality.com (Dan Ackroyd)

On Fri, 10 May 2019 at 15:42, Bishop Bettini <bishop@php.net> wrote:
>
> Extant 7.3 code might be:

People would only write code like that if they hadn't read the manual
(or code documentation in their IDE) for json_last_error() which
clearly states 'Returns the last error (if any) occurred during the
last JSON encoding/decoding,'.

> I'd rather we just raise awareness in the form of documentation

If you have to carefully read the documentation for function, and not
taking enough care means that you're going to be surprised by the
result, then the function is probably poorly designed.

> We chose one, with its pros and cons.

As we've seen recently, people don't always consider the exact detail
implications that deeply. Seeing as people can also just make wrong
choices, I think this should be changed.

Seeing as you've objected, I'll raise an RFC to put it to a vote.

cheers
Dan
Ack