Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105652 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 50330 invoked from network); 9 May 2019 17:07:29 -0000 Received: from unknown (HELO mail-lj1-f175.google.com) (209.85.208.175) by pb1.pair.com with SMTP; 9 May 2019 17:07:29 -0000 Received: by mail-lj1-f175.google.com with SMTP id 188so2139502ljf.9 for ; Thu, 09 May 2019 07:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gRloWjTNyOs5JPlPZHACXVSPlZrZtHN0Bb1UtGiCXNU=; b=ooPTK8SkIfE9N1ndtTNbZhGWs/kPkdwwMamURlJaM1zsGTC6oKLa7gmBJfxSOhiuYH wE362tr79JTS73E2Ho0FwPUoz6llvKgMjdW7qgzz7CQ2KX0rcjIt4SySti/Zf8VIxJ7b 48CibHPugeHD6gOg1vKng+GGIXVOMEQ6D335q+pWSOJImrvZAJ9QEBmqbpQ7hwkprTVv s1QAOAmyFYJ+5AyT5z94EdCg3yXz235i7C17DfZqgftZMwUQ/femntPqFXd8KVdEkCTy ljv+mGBkBtgv0JWdE+8HO5ApXrUxpcwZShk3YQeVKdb/doch2JzbmaJtRQoamhFHxPz9 3e+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gRloWjTNyOs5JPlPZHACXVSPlZrZtHN0Bb1UtGiCXNU=; b=jofR5lPCD9yn3gRwzW9NUQAhBqywfA8s47ino28iBUy7tGVh2QvQ00DfGH13+Cd6pl yUdZp8IkbbhRZTmYEcf4dqQInLd/6eBh7H4NTu4Xd7q2LPHoXWr1kriLjThk/AbCO4fD P0nHH2N5nX64OfNaqKJfWc4F9XqWXMKAFzDdx4hrNWVQAZVOcI040ZUxc6VzoYxO34R+ jb1fZz16dBqX//I6HtF95sAgp7RW99ty3wndiljJdaMlG1bInpNq8pl3iHxEHbJ7OHnN zTzZms9KKUmpg6gC4KanbdXe5xZ8CE5kyg5gULc5tYtRaWVl+Q0m7eINyaNOXfiw2Lyr 0Aog== X-Gm-Message-State: APjAAAVNeuSIjSHTHMhGM2J/v1V194WKC1kWvhGD5p2RUYQdeONITchl jwb6kP/YV4gZof+MnGudgpaWF4gDOniqgLcf1LA= X-Google-Smtp-Source: APXvYqys18cmO0bjQNAdMnEPb+Di/Du4ckTuBNF4vOSOQB9RA5MAE7wa1EQJf+KJvy35uz5ncCRQdwr4QnGF372ZXz4= X-Received: by 2002:a2e:5517:: with SMTP id j23mr2511241ljb.5.1557411113194; Thu, 09 May 2019 07:11:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Thu, 9 May 2019 16:11:36 +0200 Message-ID: To: Craig Duncan Cc: Internals Content-Type: multipart/alternative; boundary="0000000000002bd860058875086b" Subject: Re: [PHP-DEV] Using extract() with $this From: nikita.ppv@gmail.com (Nikita Popov) --0000000000002bd860058875086b Content-Type: text/plain; charset="UTF-8" On Wed, May 8, 2019 at 11:16 PM Craig Duncan wrote: > Hi everyone, > > I've just opened a pull request for some changes to *extract()* handling of > *$this* > https://github.com/php/php-src/pull/4133 > > I had a look through the original RFC discussion, and it looks like > extract() was brought up and then quickly handled, but it seems like the > handling was a bit over the top. > https://externals.io/message/93457 > > As reported in the below bug, extract() throws an exception when the > documentation suggests that it should be able to handle the scenario > (either by ignoring the request to overwrite *$this* or by creating a > prefixed version of it). > https://bugs.php.net/bug.php?id=77135 > > The only one I'm unsure of is the *IF_EXISTS* flags, as *$this* isn't in > the symbol table it's ignored even though technical *$this* does exist. But > as this is the current behaviour and doesn't cause an issue I thought for > BC it would be best to leave this behaviour alone. > > Does anybody disagree with this change? Does it need an RFC? > These changes sound reasonable to me. I don't think it needs an RFC -- this is more of a bug fix. Nikita --0000000000002bd860058875086b--