Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105649
MIME-Version: 1.0
Date: Wed, 8 May 2019 22:16:18 +0100
Message-ID: <CAHE1Edsz7LH8xvYsKMq+sVnK0dFr5MmOeub1vj1J8sAVPYy4zQ@mail.gmail.com>
To: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000dc2537058866d869"
Subject: Using extract() with $this
From: php@duncanc.co.uk (Craig Duncan)

--000000000000dc2537058866d869
Content-Type: text/plain; charset="UTF-8"

Hi everyone,

I've just opened a pull request for some changes to *extract()* handling of
*$this*
https://github.com/php/php-src/pull/4133

I had a look through the original RFC discussion, and it looks like
extract() was brought up and then quickly handled, but it seems like the
handling was a bit over the top.
https://externals.io/message/93457

As reported in the below bug, extract() throws an exception when the
documentation suggests that it should be able to handle the scenario
(either by ignoring the request to overwrite *$this* or by creating a
prefixed version of it).
https://bugs.php.net/bug.php?id=77135

The only one I'm unsure of is the *IF_EXISTS* flags, as *$this* isn't in
the symbol table it's ignored even though technical *$this* does exist. But
as this is the current behaviour and doesn't cause an issue I thought for
BC it would be best to leave this behaviour alone.

Does anybody disagree with this change? Does it need an RFC?

--000000000000dc2537058866d869--