Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105621
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
In-Reply-To: <BD53911B-2EA1-49AE-91A7-AE1DB469E8B0@koalephant.com>
Date: Tue, 7 May 2019 08:57:49 -0400
Cc: Nikita Popov <nikita.ppv@gmail.com>,
 Nicolas Grekas <nicolas.grekas@gmail.com>,
 Marco Pivetta <ocramius@gmail.com>,
 PHP Internals List <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <CED05FAD-E8F0-410E-B754-3466ADDB271A@gmail.com>
References: <FB70FDD7-53AA-4DB4-B747-6E109BE52C2E@gmail.com>
 <CADyq6sJZjFQm0W+P=7C0CWp-TbiL2kUL-yJLCbZcmU0Ycc6cuQ@mail.gmail.com>
 <CAOWwgpnASj3j8BXqoMAOhuHntmwOroivvNybbxxZV-GE_kaXqw@mail.gmail.com>
 <E7C478BC-DAE0-4C25-B54E-BD9852199D40@gmail.com>
 <CAF+90c-7kE0hK1sPgBET-1OnOM0nnPGX8EvkSV+ifo14X7xGpA@mail.gmail.com>
 <76C69198-A778-4B60-8EBF-8BDEC7D2DBC1@koalephant.com>
 <BE4847EC-E426-4A52-8217-B70798C148C2@gmail.com>
 <BD53911B-2EA1-49AE-91A7-AE1DB469E8B0@koalephant.com>
To: Stephen Reay <php-lists@koalephant.com>
Subject: Re: [PHP-DEV] Proposal for a RFC
From: stevenwadejr@gmail.com (Steven Wade)



> On May 7, 2019, at 8:52 AM, Stephen Reay <php-lists@koalephant.com> =
wrote:
>=20
>=20
>> On 7 May 2019, at 19:47, Steven Wade <stevenwadejr@gmail.com> wrote:
>>=20
>>> Maybe I=E2=80=99m missing the point (I=E2=80=99ve never used it) of =
VarDumper, but isn=E2=80=99t this type of thing exactly why the =
`__debugInfo` magic method exists?
>>=20
>>=20
>> I can't speak for the exact reason a library like VarDumper is using =
casting versus __debugInfo, but in trying to find a substitute this =
morning, I played with the method you mentioned and found that it can be =
overwritten by classes and be commanded to not return anything (similar =
to my __toArray proposal), whereas current functionality prevents =
overriding casting to an array so casting will always give you insight =
but users can overwrite __debugInfo and cause unintended effects. I =
assume that's the reason for not using __debugInfo.
>>=20
>> --
>> Steven Wade
>> stevenwadejr@gmail.com
>>=20
>>=20
>>=20
>=20
> Right, I understand that it *can* be overridden, but surely if =
someone=E2=80=99s doing that, its because they want more useful =
information provided in, e.g. var_dump.


I think that's a good point. If we follow that mentality, then the =
proposed __toArray and it's subsequent ability to affect array casting =
isn't a worry too much as the proposal is to only call __toArray if it =
exists and an object is cast to an array, so if a user manually =
implements __toArray, then we could assume "they want more useful =
information provided in, e.g. var_dump."

--
Steven Wade
stevenwadejr@gmail.com