Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105584
MIME-Version: 1.0
References: <3f5873fe-3fe9-d230-28eb-a20d67550b45@lange.demon.co.uk>
 <d5abeebe-12df-97dc-d8ca-5eb40fb29976@lange.demon.co.uk> <CAP=4hCKiGYjh4-MVu-0nmm8PS=uaEXBoRL4sGyjtMLYqUdkjjQ@mail.gmail.com>
In-Reply-To: <CAP=4hCKiGYjh4-MVu-0nmm8PS=uaEXBoRL4sGyjtMLYqUdkjjQ@mail.gmail.com>
Date: Sat, 4 May 2019 03:05:14 +0200
Message-ID: <CAAfnsFXC_zVn4YeSkK36=tPW0=enaP+ooub7e6+aRr3bPQumCg@mail.gmail.com>
To: Gabriel Caruso <carusogabriel34@gmail.com>
Cc: Mark Baker <mark@lange.demon.co.uk>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] 2016 TestFest, did the tests written then ever get merged?
From: peterkokot@gmail.com (Peter Kokot)

Hello,

On Sat, 9 Feb 2019 at 17:38, Gabriel Caruso <carusogabriel34@gmail.com> wro=
te:
>
> Em s=C3=A1b, 9 de fev de 2019 =C3=A0s 06:08, Mark Baker <mark@lange.demon=
.co.uk>
> escreveu:
>
> > On 06/02/2019 08:13, Mark Baker wrote:
> > > Looking at the Voting Eligibility discussion going on at the moment.
> > >
> > > I, like many others, participated in the last testfest 18 months or s=
o
> > > ago. Did the results from that ever get merged? Or have they simply b=
een
> > > discarded or forgotten? If merged, they certainly don't show up in th=
e
> > > contributions list posted aganst the Workflow and Voting RFC Eligibil=
ity
> > > list: yet all those who participated in the testfest care about the
> > > language enough to get involved
> > >
> > >
> > Thank you. It's good to see merging has started. I appreciate your work=
,
> > as I'm sure will many of those who contributed through the TestFest
> >
> >
> > --
> > Mark Baker
> >
> >   _________
> > |.  \     \-3
> > |_J_/ PHP |
> > || |  __  |
> > || |m|  |m|
> >
> >   I LOVE PHP
> >
> >
>
> Hello everyone.
>
> I've reviewed a couple of those PRs, closing some ZPP Failures tests and
> duplicated ones and now we have 94 to go. Some of them I've left a commen=
t
> to adjust the test to get merge, others, I'm not familiar with the
> extension/function/test to approve. If someone wants to take a look and
> help us finish this task, I'd appreciated it :)
>
> https://github.com/phpcommunity/phptestfest-php-src/pulls
>
> Best,
> --
> Gabriel Caruso

I want to thank everyone who have sent their pull requests to the test
fest repository or have in any other way joined and participated in
the PHP test fest event.

I thought we could merge all the pull requests properly in few months
but unfortunately that's it from my side in the given time frame that
was set for this part. We have merged several pull requests that could
be added in the upstream repository others should be done manually but
I simply don't have time to go through each manually anymore. If
anyone would like to see their contribution noted in the php-src
repository, please reopen the pull request in the php-src repository
directly. It's very simple (and in most cases hopefully welcoming
enough) to send your pull request there. If not ping me up to check
your pull requests per manual basis.

A friendly nudge to the organizers... Next time, don't be shy and
please please avoid doing forks of this repo and let's do the noise
directly on the php-src repo. As we see, it is almost near impossible
to solve this properly and give everyone credits they deserve and
merge all the pull requests there without manual commits and rechecks
without the help of the internals people.

Cheers and thanks.


--=20
Peter Kokot