Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105580
To: PHP internals <internals@lists.php.net>
References: <b6f883a4-eb6b-f151-8867-e41ce00b7ead@gmx.de>
Message-ID: <84fb3239-8415-9352-dd2c-c5362cb2befa@gmx.de>
Date: Fri, 3 May 2019 12:44:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <b6f883a4-eb6b-f151-8867-e41ce00b7ead@gmx.de>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: Remove $age parameter of curl_version()
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 01.05.2019 at 19:18, Christoph M. Becker wrote:

> curl_version()[1] (of ext/curl) makes curl_version_info()[2] (of
> libcurl) available to PHP userland.  The latter requires to pass an age
> argument which usually is CURLVERSION_NOW, so that the information
> returned by the runtime matches the declarations used during compile
> time.  For C programs it is simply necessary to pass this information,
> and it might make sense to pass something else than CURLVERSION_NOW, but
> the PHP wrapper assumes that the return value of curl_version_info()
> matches the compile time declarations anyway, so passing anything else
> might give bad results.
>
> Therefore I suggest to remove this parameter in the long run altogether.
>  For PHP 7.4 I suggest to deprecate using the parameter, and also to
> ignore anything that is not CURLVERSION_NOW, and to raise a warning in
> this case.  I.e. something like the following behavior:
>
>    // okay
>   curl_version();
>
>   // E_DEPRECATED: passing an argument is deprecated
>   curl_version(CURLVERSION_NOW);
>
>   // E_WARNING: argument ignored
>   curl_version($not_curlversion_now);
>
> Thoughts?  Do I overlook something important?
>
> [1] <https://www.php.net/manual/en/function.curl-version.php>
> [2] <https://curl.haxx.se/libcurl/c/curl_version_info.html>

I have submitted PR #4106[3] to address this issue.  Of course, ignoring
anything else than CURLVERSION_NOW would be a BC break, and is as such
debatable.  Also, the deprecation should be followed by an actual
removal sometime in the future, so likely there should be a respective
RFC -- or can we do without in this case?

[3] <https://github.com/php/php-src/pull/4106>

=2D-
Christoph M. Becker