Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105566
MIME-Version: 1.0
References: <b6f883a4-eb6b-f151-8867-e41ce00b7ead@gmx.de> <CAEYWF=5T6GSSmuo4AYr1j_0d4m+=2XOSBtaVst_fP1_WF_aJ=g@mail.gmail.com>
 <4813ca95-2617-b892-3e53-8ee175e64187@gmx.de>
In-Reply-To: <4813ca95-2617-b892-3e53-8ee175e64187@gmx.de>
Reply-To: bishop@php.net
Date: Thu, 2 May 2019 13:00:00 -0400
Message-ID: <CAEYWF=4Co736=oCGwbkzoDjahSUwbjRBoV0hsfDYXM5b0du+dw@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005ffee20587ea9306"
Subject: Re: [PHP-DEV] Remove $age parameter of curl_version()
From: bishop@php.net (Bishop Bettini)

--0000000000005ffee20587ea9306
Content-Type: text/plain; charset="UTF-8"

On Thu, May 2, 2019 at 3:58 AM Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> On 01.05.2019 at 19:40, Bishop Bettini wrote:
>
> > On Wed, May 1, 2019 at 1:18 PM Christoph M. Becker <cmbecker69@gmx.de>
>
> >> Thoughts?  Do I overlook something important?
> >
> > Well, what about:
> >
> > if (false === curl_version(3)) {
> >     throw new \Exception('Please rebuild PHP with curl at least
> > version 7.16.1');
> > }
>
> It seems to me that wouldn't work anyway, since curl_version() only
> returns false if curl_version_info() returned NULL, but that won't
> happen[2].
>
> > [1]:
> https://github.com/php/php-src/blob/master/ext/curl/interface.c#L1824
>
> [2]
> <
> https://github.com/curl/curl/blob/d1b5cf830bfe169745721b21245d2217d2c2453e/lib/version.c#L390-L463
> >
>

Indeed. In that case, I cannot see any value from the $age parameter. It
seems to be only an overly-literal functionality translation. I'm in favor
of removal.

--0000000000005ffee20587ea9306--