Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105554
To: bishop@php.net
Cc: PHP internals <internals@lists.php.net>
References: <b6f883a4-eb6b-f151-8867-e41ce00b7ead@gmx.de>
 <CAEYWF=5T6GSSmuo4AYr1j_0d4m+=2XOSBtaVst_fP1_WF_aJ=g@mail.gmail.com>
Message-ID: <4813ca95-2617-b892-3e53-8ee175e64187@gmx.de>
Date: Thu, 2 May 2019 09:58:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAEYWF=5T6GSSmuo4AYr1j_0d4m+=2XOSBtaVst_fP1_WF_aJ=g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Remove $age parameter of curl_version()
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 01.05.2019 at 19:40, Bishop Bettini wrote:

> On Wed, May 1, 2019 at 1:18 PM Christoph M. Becker <cmbecker69@gmx.de>
> wrote:
>
>> curl_version()[1] (of ext/curl) makes curl_version_info()[2] (of
>> libcurl) available to PHP userland.  The latter requires to pass an age
>> argument which usually is CURLVERSION_NOW, so that the information
>> returned by the runtime matches the declarations used during compile
>> time.  For C programs it is simply necessary to pass this information,
>> and it might make sense to pass something else than CURLVERSION_NOW, bu=
t
>> the PHP wrapper assumes that the return value of curl_version_info()
>> matches the compile time declarations anyway, so passing anything else
>> might give bad results.
>
> It looks like the ext/curl binding [1] handles run-time age values that
> differ from compile-time, as it makes checks for if (d->age). Am I missi=
ng
> something?

Indeed, as the binding is written, it's unlikely that bad results are
returned.  Still, using a newer "age" than available at compile time
will neither provide the PHP program more information, nor would using
an older "age" have real benefits.

>> Thoughts?  Do I overlook something important?
>
> Well, what about:
>
> if (false =3D=3D=3D curl_version(3)) {
>     throw new \Exception('Please rebuild PHP with curl at least
> version 7.16.1');
> }

It seems to me that wouldn't work anyway, since curl_version() only
returns false if curl_version_info() returned NULL, but that won't
happen[2].

> [1]: https://github.com/php/php-src/blob/master/ext/curl/interface.c#L18=
24

[2]
<https://github.com/curl/curl/blob/d1b5cf830bfe169745721b21245d2217d2c2453=
e/lib/version.c#L390-L463>

=2D-
Christoph M. Becker