Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105552 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 45711 invoked from network); 2 May 2019 04:58:49 -0000 Received: from unknown (HELO mail-vs1-f44.google.com) (209.85.217.44) by pb1.pair.com with SMTP; 2 May 2019 04:58:49 -0000 Received: by mail-vs1-f44.google.com with SMTP id b23so480745vso.1 for ; Wed, 01 May 2019 19:01:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=Za74N3V2fFzuaHuTHzCe0SMi4X4irokNn3N/ipxUl6o=; b=kYas/F5va+vdKiNEPDVZY7Qf+y7HJip6Yl/Xq8JPkNGt1d8ZGFg4R6JTZt6N8d8gfE e5uIHK7DRp2xZ2CV4sZP9Q7G7/KsfkexlJ56EDwQbNBjchiN6qyGyHNMa8XgZz3XA5eO +Ug5ZtiFxEnGLbDYP1blywJfi9kqgNarttbNcXbTrRY9p1MGF+dLNjWFYcvN5ZJNS6Zz KcJHk2ty20WAXJ45JV4NBkuT3m/DB0vl7Hsd6T2lwQfpIhMAJ5Gkz5HVt0lIChTbr9ml jrTl7j5PcRXVp1NROxVxIxP8NXL723CLt3HurJZckQgQTr/MguARt5YiP4FnVgA1r50r zXpA== X-Gm-Message-State: APjAAAVBbGnvdGJZOm4vw/ZSwuJPizICfFV8TXR6sZ83FXH9bspNbzYi DGh5/ap/82rP5V9YNDAaiBEatDxdDCXc9k6rhOs= X-Google-Smtp-Source: APXvYqxpLs/9K6xfgSJpcIDn7SeZrnxlO3iZ5u1chY0lnMn/w3PyYf8mqVmEo3/hTlD8+jmbsgJkrVPpKpjv7BLk1aA= X-Received: by 2002:a67:f30f:: with SMTP id p15mr626089vsf.158.1556762481054; Wed, 01 May 2019 19:01:21 -0700 (PDT) MIME-Version: 1.0 References: <9a90b882-b6d5-a36c-20db-318c79cf5028@gmail.com> In-Reply-To: Reply-To: bishop@php.net Date: Wed, 1 May 2019 22:00:53 -0400 Message-ID: To: Thomas Punt Cc: Theodore Brown , PHP internals Content-Type: multipart/alternative; boundary="000000000000aed6bb0587de0251" Subject: Re: [PHP-DEV] Revive Number Format Separator RFC From: bishop@php.net (Bishop Bettini) --000000000000aed6bb0587de0251 Content-Type: text/plain; charset="UTF-8" On Wed, May 1, 2019 at 5:42 AM Thomas Punt wrote: > Hi! > > > On Wed, May 01, 2019 at 01:13 AM Bishop Bettini wrote: > > > On Tue, Apr 30, 2019, 19:14 Theodore Brown wrote: > > > > > > On Tue, Apr 30, 2019 at 3:59 PM Bishop Bettini wrote: > > > > > > > Excellent. I hope we can make the case this time. Please > > > > request Wiki karma [1], and we'll iterate on it there. > > > > > > I was granted karma, and published an initial RFC draft: > > > https://wiki.php.net/rfc/numeric_literal_separator. > > > > > > I would greatly appreciate help with the implementation, since I > > > don't have much experience with C and haven't contributed to PHP > before. > > > > > > Also let me know if you have any ideas for improving the RFC. > > > > > > > I am happy to help with these. Let us take the RFC refinement and > > implementation details conversation off-list. Then come back when > prepared > > to present for discussion. > > I would think that pretty much the whole of the original implementation[1] > should > be reusable (maybe some merge conflicts to fix only). But anyway, I can > offer some > support with the implementation, if needed. > Great, thanks Tom. Theodore and I are polishing the RFC, then will tackle the implementation. Besides the necessary merge fixes, are there any changes/improvements you specifically want to make in the new proposed implementation? --000000000000aed6bb0587de0251--