Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105550
MIME-Version: 1.0
References: <b6f883a4-eb6b-f151-8867-e41ce00b7ead@gmx.de>
In-Reply-To: <b6f883a4-eb6b-f151-8867-e41ce00b7ead@gmx.de>
Date: Wed, 1 May 2019 21:07:10 +0200
Message-ID: <CAF+90c_hAE-s97pK_OS-jZ08irrwp37Ewx19f-TF=UX-fjoE8w@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000077b59d0587d83afe"
Subject: Re: [PHP-DEV] Remove $age parameter of curl_version()
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000077b59d0587d83afe
Content-Type: text/plain; charset="UTF-8"

On Wed, May 1, 2019 at 7:19 PM Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> Hi,
>
> curl_version()[1] (of ext/curl) makes curl_version_info()[2] (of
> libcurl) available to PHP userland.  The latter requires to pass an age
> argument which usually is CURLVERSION_NOW, so that the information
> returned by the runtime matches the declarations used during compile
> time.  For C programs it is simply necessary to pass this information,
> and it might make sense to pass something else than CURLVERSION_NOW, but
> the PHP wrapper assumes that the return value of curl_version_info()
> matches the compile time declarations anyway, so passing anything else
> might give bad results.
>
> Therefore I suggest to remove this parameter in the long run altogether.
>  For PHP 7.4 I suggest to deprecate using the parameter, and also to
> ignore anything that is not CURLVERSION_NOW, and to raise a warning in
> this case.  I.e. something like the following behavior:
>
>    // okay
>   curl_version();
>
>   // E_DEPRECATED: passing an argument is deprecated
>   curl_version(CURLVERSION_NOW);
>
>   // E_WARNING: argument ignored
>   curl_version($not_curlversion_now);
>
> Thoughts?  Do I overlook something important?
>

Sounds good to me.

Nikita

--00000000000077b59d0587d83afe--