Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105539
MIME-Version: 1.0
References: <CAF+90c-3TcEME_993vxvbhgCsKCrVVMSLobjrc=-EUZOmxYRYg@mail.gmail.com>
 <CA+kxMuSPDckN+YDN-PuqU-YXKm08fyTWh_7yK0YecTSJOFLfvA@mail.gmail.com> <2b141597-e68e-1843-51f5-16d6ed8c41fa@gmail.com>
In-Reply-To: <2b141597-e68e-1843-51f5-16d6ed8c41fa@gmail.com>
Reply-To: bishop@php.net
Date: Tue, 30 Apr 2019 22:53:00 -0400
Message-ID: <CAEYWF=5Yay7SvL5wCe9WjwdWW+HD_Ht0a+TtFzeTB1R5wmE0xQ@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: Dan Ackroyd <Danack@basereality.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001388010587caa29d"
Subject: Re: [PHP-DEV] [RFC] Allow throwing exceptions from __toString()
From: bishop@php.net (Bishop Bettini)

--0000000000001388010587caa29d
Content-Type: text/plain; charset="UTF-8"

On Tue, Apr 30, 2019 at 2:49 PM Stanislav Malyshev <smalyshev@gmail.com>
wrote:

>
> That said, the work done on the patch is super impressive. I am
> reasonably sure that Nikita caught as many instances of something going
> wrong when string conversion fails as humanly possible. And I agree that
> banning exceptions didn't actually solve the problem anyway, because
> error handlers present the same exactly issue - exceptions are just much
> more prominent and immediate in their effects, but with some hostile
> coding - or even some inadvertently convoluted one - you'd run into the
> same issues again. Some extensions will probably have some trouble -
> though with high likelyhood they already do anyway.


I second that "super impressive work". I'm certain some of why it's been
deferred is because doing it was, well, unpleasant. Thanks Nikita for
wrestling this.

I spent an hour today going through the patch, especially its effect on the
phar and imap extensions, and Zend/*. The patch seems good to me, minus a
few targeted comments. But I'd still think this would be a "many eyes
needed" kind of PR, especially from extension maintainers.

+1 from me.

--0000000000001388010587caa29d--