Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105485
To: Stanislav Malyshev <smalyshev@gmail.com>, "bishop@php.net"
	<bishop@php.net>, PHP internals <internals@lists.php.net>
Thread-Topic: [PHP-DEV] Revive Number Format Separator RFC
Thread-Index: AQHU+7D7OGXgdVHJp0Ci/FG71ATk06ZNpzIAgAA/dgCAAwXyAIAA1mMz
Date: Sun, 28 Apr 2019 17:47:33 +0000
Message-ID: <MWHPR06MB28613B6142B1E33A8AEC7328DE380@MWHPR06MB2861.namprd06.prod.outlook.com>
References: <DM5PR06MB28578FFCD3349CF7F41F33FDDE3D0@DM5PR06MB2857.namprd06.prod.outlook.com>
 <CAEYWF=7dVBsbFUnK27OV7rfg7e=rsZ9jcv0Q=VFKND6p=OPYFA@mail.gmail.com>
 <CAEYWF=7s5CW-zAobmJYvr5hj9-K7gU123WVkjZwnth-p-9uYLQ@mail.gmail.com>,<9a90b882-b6d5-a36c-20db-318c79cf5028@gmail.com>
In-Reply-To: <9a90b882-b6d5-a36c-20db-318c79cf5028@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [5IoJqhgc/usmw/Gxkd1UXymlnkyMwR1t]
x-ms-publictraffictype: Email
x-incomingheadercount: 43
x-eopattributedmessage: 0
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(5050001)(7020095)(20181119110)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045);SRVR:SN1NAM02HT019;
x-ms-traffictypediagnostic: SN1NAM02HT019:
x-microsoft-antispam-message-info: +8BBo80bppC/DOtVEF9SSy/lgAaSCMkz9/dnKzpQSp0OdOgc761Wo0DNj49/XE1uUgoWIVpET+L8tMtEzB09yW4PEycvyhUiw2WrKqADzAzX4wPSFILWwMKfxu21YfVC/5XkPlONE5JnNI+5xmITFVQUXHl69FAV85fx98ScDMKNyY6ttj7HuIcO+KajbewO
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dc1fd2e-a2bc-4ff0-def6-08d6cc019822
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2019 17:47:33.8299
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT019
Subject: Re: [PHP-DEV] Revive Number Format Separator RFC
From: theodorejb@outlook.com (Theodore Brown)

On Sat, Apr 27, 2019 at 10:25 PM Stanislav Malyshev <smalyshev@gmail.com> w=
rote:=0A=
=0A=
> I am not exactly against this feature, but the potential for abuse=0A=
> \- like enabling people using integers for things that are not=0A=
> integers and should not be stored as integers - worries me now.=0A=
=0A=
Based on the usage analysis Bishop did, people already use integers=0A=
for number-like values (e.g. phone and social security numbers) that=0A=
can be better represented in other ways.=0A=
=0A=
Perhaps adding the numeric separator feature can actually be an=0A=
opportunity to discourage such misuse. We can add a paragraph to the=0A=
RFC (and the documentation if it is accepted) that lists examples of=0A=
usage that should be avoided.=0A=
=0A=
Ultimately there remains many legitimate uses of large numbers in=0A=
code (e.g. scientific constants, unit test values, business logic=0A=
thresholds, etc.), and this feature is a simple way to improve their=0A=
readability.=0A=
=0A=
I've lost count of the number of times I've been debugging a failing=0A=
test and struggling to count the number and position of digits to=0A=
make sure I have the right value. This feature would save time when=0A=
reading code and indeed prevent a lot of mistakes in the first place.=