Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105484
Return-Path: <kontakt@beberlei.de>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 62595 invoked from network); 28 Apr 2019 18:44:38 -0000
Received: from unknown (HELO mail-lf1-f67.google.com) (209.85.167.67)
  by pb1.pair.com with SMTP; 28 Apr 2019 18:44:38 -0000
Received: by mail-lf1-f67.google.com with SMTP id t11so5922079lfl.12
        for <internals@lists.php.net>; Sun, 28 Apr 2019 08:46:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=beberlei-de.20150623.gappssmtp.com; s=20150623;
        h=mime-version:from:date:message-id:subject:to;
        bh=WS0Hbz3jFBSjZ3pnLylhpl033a2kEBgR+KXl7+e5eAg=;
        b=QgHLMcOOJIN+V3iQU7FAqIvW6GlGL2UbEHw+9UjzGH9WSR5mz8gXEcC/qe9ruznZwA
         UDXDpWrhlplxILP5iZwVIkWwAdH6M51IIYZagE9iR38hE6mL91vZsSsfhNGAa+zRt8fI
         1/IXNJAzfiRqn7P52jpgR+wvsRMD2lL/ZHviVzXbgo9Rx+rBnahAhOmTqwNnUfqgcDQW
         DxryykEnAnuY5DGSkAxLmVd9Ui8t+dIr/XshLavnRYtPKM734vLdfXPXXGsRJqLuQYzo
         JV6hz7bs5svOnVk0NzKgmXmiuIZqzMNzniJdp+cMYvH9dTVXQN1I6cRcOFljulDwll/F
         OsDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=WS0Hbz3jFBSjZ3pnLylhpl033a2kEBgR+KXl7+e5eAg=;
        b=Q+gtJYmYkznEPUZVe7xo2qy6KkaEoZfxIVf4XQtHrREQVlZN7LPPAhlXVA/ckeLu9P
         IYfotohurm+cHhL8zga20CDmOdH+Xw+om6KtDaIdK7BCEnbpQXNdiCGs71762iViVCYR
         VyXWamP0NtFdcz+jXF4JdX9KufBLo4s0Fe3y8A4HTK2QN/9Z4KxQiBV1pCOxt1KneoEp
         k7Lp20VbyXiOAikfwqNZymw5bBUOrH7C/b0OQ9ZWuC9TX0WiLCLpJibav1dxxtKAJDhX
         I3Ut2WP6YkAihj1vv7ZK0GrhJioSGLGME4HYRDasiTb0zkLDoHMkAWE5w99z4TE7d3zz
         JNTw==
X-Gm-Message-State: APjAAAVxdlbN0uHYlB1h0Fg45jJHZa81PjbLvEVrtd/AC9caJlDcJgBh
	WivzHhgNi+ZovtdKzr7DR3XRVVs7zmn8tSVdMj/KXtwiIe1lxA==
X-Google-Smtp-Source: APXvYqxpEX4JRTKjk/lArKsHtvxNbbbvkf1kXGShczuatpBF8dpqrYtRIdFsxcEmljONTyH8KQS7uoR613bdNVuHW/M=
X-Received: by 2002:a19:5f51:: with SMTP id a17mr10661354lfj.131.1556466377982;
 Sun, 28 Apr 2019 08:46:17 -0700 (PDT)
MIME-Version: 1.0
Date: Sun, 28 Apr 2019 17:46:06 +0200
Message-ID: <CAEPJduk3ftsDouOLNk1JUwVy07Qawg_VpxMD73Z2kFRAL17-aw@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000090a0a805879911d5"
Subject: Adding special case for "eval" in disable_functions INI setting
From: kontakt@beberlei.de (Benjamin Eberlei)

--00000000000090a0a805879911d5
Content-Type: text/plain; charset="UTF-8"

Hi everyone,

I have added a patch to introduce a special case for eval when listed in
disable_functions INi setting. From a developer perspective it shouldn't be
necessary to know that eval is not a function but a language construct.
This is why I think this special case is needed rather than adding a new
INI setting.

https://github.com/php/php-src/pull/4084

The patch fixes https://bugs.php.net/bug.php?id=62397

It currently targets 7.4 branch, but the way its implemented I think it
could be merged into the stable branches.

Should I target the PR for 7.1/7.2 or where do the PMs think this should go?

greetings
Benjamin

--00000000000090a0a805879911d5--